Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-30 Thread Michal Hocko
On Wed 25-11-20 14:24:45, Feng Tang wrote: [...] > I think we finally found the trick :), further debugging shows it > is not related to the alignment inside one cacheline, but the > adjacency of 2 adjacent cacheliens (2N and 2N+1, one pair of 128 bytes). > > For structure mem_cgroup, member

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-26 Thread Linus Torvalds
On Tue, Nov 24, 2020 at 10:24 PM Feng Tang wrote: > > And with the following patch to relayout these members, the regression > is restored and event better. while reducing 64 bytes of sizeof > 'struct mem_cgroup' Thanks, applied. I do wonder if somebody on the hardware side inside Intel might

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-25 Thread Waiman Long
On 11/25/20 1:24 AM, Feng Tang wrote: On Fri, Nov 20, 2020 at 07:44:24PM +0800, Feng Tang wrote: On Fri, Nov 13, 2020 at 03:34:36PM +0800, Feng Tang wrote: I would rather focus on a more effective mem_cgroup layout. It is very likely that we are just stumbling over two counters here. Could

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-24 Thread Feng Tang
On Fri, Nov 20, 2020 at 07:44:24PM +0800, Feng Tang wrote: > On Fri, Nov 13, 2020 at 03:34:36PM +0800, Feng Tang wrote: > > > I would rather focus on a more effective mem_cgroup layout. It is very > > > likely that we are just stumbling over two counters here. > > > > > > Could you try to add

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-20 Thread Feng Tang
On Fri, Nov 20, 2020 at 02:19:44PM +0100, Michal Hocko wrote: > On Fri 20-11-20 19:44:24, Feng Tang wrote: > > On Fri, Nov 13, 2020 at 03:34:36PM +0800, Feng Tang wrote: > > > On Thu, Nov 12, 2020 at 03:16:54PM +0100, Michal Hocko wrote: > > > > > > > I add one phony page_counter after the union

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-20 Thread Michal Hocko
On Fri 20-11-20 19:44:24, Feng Tang wrote: > On Fri, Nov 13, 2020 at 03:34:36PM +0800, Feng Tang wrote: > > On Thu, Nov 12, 2020 at 03:16:54PM +0100, Michal Hocko wrote: > > > > > > I add one phony page_counter after the union and re-test, the > > > > > > regression > > > > > > reduced to -1.2%.

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-20 Thread Feng Tang
On Fri, Nov 13, 2020 at 03:34:36PM +0800, Feng Tang wrote: > On Thu, Nov 12, 2020 at 03:16:54PM +0100, Michal Hocko wrote: > > > > > I add one phony page_counter after the union and re-test, the > > > > > regression > > > > > reduced to -1.2%. It looks like the regression caused by the data > >

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-12 Thread Feng Tang
On Thu, Nov 12, 2020 at 11:43:45AM -0500, Waiman Long wrote: > >>We tried below patch to make the 'page_counter' aligned. > >> diff --git a/include/linux/page_counter.h b/include/linux/page_counter.h > >> index bab7e57..9efa6f7 100644 > >> --- a/include/linux/page_counter.h > >> +++

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-12 Thread Feng Tang
On Thu, Nov 12, 2020 at 03:16:54PM +0100, Michal Hocko wrote: > On Thu 12-11-20 20:28:44, Feng Tang wrote: > > Hi Michal, > > > > On Wed, Nov 04, 2020 at 09:15:46AM +0100, Michal Hocko wrote: > > > > > > Hi Michal, > > > > > > > > > > > > We used the default configure of cgroups, not sure what

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-12 Thread Waiman Long
On 11/12/20 9:16 AM, Michal Hocko wrote: On Thu 12-11-20 20:28:44, Feng Tang wrote: Hi Michal, On Wed, Nov 04, 2020 at 09:15:46AM +0100, Michal Hocko wrote: Hi Michal, We used the default configure of cgroups, not sure what configuration you want, could you give me more details? and here is

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-12 Thread Michal Hocko
On Thu 12-11-20 20:28:44, Feng Tang wrote: > Hi Michal, > > On Wed, Nov 04, 2020 at 09:15:46AM +0100, Michal Hocko wrote: > > > > > Hi Michal, > > > > > > > > > > We used the default configure of cgroups, not sure what configuration > > > > > you > > > > > want, > > > > > could you give me more

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-12 Thread Feng Tang
Hi Michal, On Wed, Nov 04, 2020 at 09:15:46AM +0100, Michal Hocko wrote: > > > > Hi Michal, > > > > > > > > We used the default configure of cgroups, not sure what configuration > > > > you > > > > want, > > > > could you give me more details? and here is the cgroup info of > > > >

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-04 Thread Michal Hocko
On Wed 04-11-20 09:20:04, Xing Zhengjun wrote: > > > On 11/2/2020 6:02 PM, Michal Hocko wrote: > > On Mon 02-11-20 17:53:14, Rong Chen wrote: > > > > > > > > > On 11/2/20 5:27 PM, Michal Hocko wrote: > > > > On Mon 02-11-20 17:15:43, kernel test robot wrote: > > > > > Greeting, > > > > > > >

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-03 Thread Waiman Long
On 11/3/20 8:20 PM, Xing Zhengjun wrote: On 11/2/2020 6:02 PM, Michal Hocko wrote: On Mon 02-11-20 17:53:14, Rong Chen wrote: On 11/2/20 5:27 PM, Michal Hocko wrote: On Mon 02-11-20 17:15:43, kernel test robot wrote: Greeting, FYI, we noticed a -22.7% regression of

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-03 Thread Xing Zhengjun
On 11/2/2020 6:02 PM, Michal Hocko wrote: On Mon 02-11-20 17:53:14, Rong Chen wrote: On 11/2/20 5:27 PM, Michal Hocko wrote: On Mon 02-11-20 17:15:43, kernel test robot wrote: Greeting, FYI, we noticed a -22.7% regression of will-it-scale.per_process_ops due to commit: commit:

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-02 Thread Michal Hocko
On Mon 02-11-20 17:53:14, Rong Chen wrote: > > > On 11/2/20 5:27 PM, Michal Hocko wrote: > > On Mon 02-11-20 17:15:43, kernel test robot wrote: > > > Greeting, > > > > > > FYI, we noticed a -22.7% regression of will-it-scale.per_process_ops due > > > to commit: > > > > > > > > > commit:

Re: [LKP] Re: [mm/memcg] bd0b230fe1: will-it-scale.per_process_ops -22.7% regression

2020-11-02 Thread Rong Chen
On 11/2/20 5:27 PM, Michal Hocko wrote: On Mon 02-11-20 17:15:43, kernel test robot wrote: Greeting, FYI, we noticed a -22.7% regression of will-it-scale.per_process_ops due to commit: commit: bd0b230fe14554bfffbae54e19038716f96f5a41 ("mm/memcg: unify swap and memsw page counters")