Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-26 Thread Ondrej Zary
On Friday 26 October 2012, H. Peter Anvin wrote: > My guess is that Windows explicitly enables A20 on resume. We should do > that too, really... with the current heavily unified realmode code it > should be easy - let me hack up a patch in the morning. Neither s3_beep nor s3_leds (this patch:

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-26 Thread Ondrej Zary
On Friday 26 October 2012, H. Peter Anvin wrote: My guess is that Windows explicitly enables A20 on resume. We should do that too, really... with the current heavily unified realmode code it should be easy - let me hack up a patch in the morning. Neither s3_beep nor s3_leds (this patch:

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-25 Thread H. Peter Anvin
My guess is that Windows explicitly enables A20 on resume. We should do that too, really... with the current heavily unified realmode code it should be easy - let me hack up a patch in the morning. Robert Hancock wrote: >On 10/24/2012 02:09 PM, Alan Cox wrote: >> On Wed, 24 Oct 2012 12:36:04

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-25 Thread Robert Hancock
On 10/24/2012 02:09 PM, Alan Cox wrote: On Wed, 24 Oct 2012 12:36:04 -0700 "H. Peter Anvin" wrote: Minor concern: it should do the wait for ready before sending each command. Can we get a command line to do this quirk too - it strikes me that if the MSIs rely upon it then it may be

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-25 Thread Robert Hancock
On 10/24/2012 02:09 PM, Alan Cox wrote: On Wed, 24 Oct 2012 12:36:04 -0700 H. Peter Anvin h...@zytor.com wrote: Minor concern: it should do the wait for ready before sending each command. Can we get a command line to do this quirk too - it strikes me that if the MSIs rely upon it then it may

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-25 Thread H. Peter Anvin
My guess is that Windows explicitly enables A20 on resume. We should do that too, really... with the current heavily unified realmode code it should be easy - let me hack up a patch in the morning. Robert Hancock hancock...@gmail.com wrote: On 10/24/2012 02:09 PM, Alan Cox wrote: On Wed, 24

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-24 Thread Alan Cox
On Wed, 24 Oct 2012 12:36:04 -0700 "H. Peter Anvin" wrote: > Minor concern: it should do the wait for ready before sending each command. Can we get a command line to do this quirk too - it strikes me that if the MSIs rely upon it then it may be something Windows always does so will be useful to

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-24 Thread H. Peter Anvin
Probably should. Ondrej Zary wrote: >On Wednesday 24 October 2012 21:36:04 H. Peter Anvin wrote: >> Minor concern: it should do the wait for ready before sending each >command. > >It was a hack and then I forgot to add the waits... Should I redo the >patch? >I'll not be able to test it as I

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-24 Thread Ondrej Zary
On Wednesday 24 October 2012 21:36:04 H. Peter Anvin wrote: > Minor concern: it should do the wait for ready before sending each command. It was a hack and then I forgot to add the waits... Should I redo the patch? I'll not be able to test it as I have to return the machine. > "Rafael J.

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-24 Thread H. Peter Anvin
Minor concern: it should do the wait for ready before sending each command. "Rafael J. Wysocki" wrote: >On Wednesday 24 of October 2012 08:47:52 Ondrej Zary wrote: >> Some MSI laptop BIOSes are broken - INT 15h code uses port 92h to >enable A20 >> line but resume code assumes that KBC was used.

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-24 Thread Rafael J. Wysocki
On Wednesday 24 of October 2012 08:47:52 Ondrej Zary wrote: > Some MSI laptop BIOSes are broken - INT 15h code uses port 92h to enable A20 > line but resume code assumes that KBC was used. > The laptop will not resume from S3 otherwise but powers off after a while > and then powers on again stuck

[PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-24 Thread Ondrej Zary
Some MSI laptop BIOSes are broken - INT 15h code uses port 92h to enable A20 line but resume code assumes that KBC was used. The laptop will not resume from S3 otherwise but powers off after a while and then powers on again stuck with a blank screen. Fix it by enabling A20 using KBC. Affected

[PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-24 Thread Ondrej Zary
Some MSI laptop BIOSes are broken - INT 15h code uses port 92h to enable A20 line but resume code assumes that KBC was used. The laptop will not resume from S3 otherwise but powers off after a while and then powers on again stuck with a blank screen. Fix it by enabling A20 using KBC. Affected

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-24 Thread Rafael J. Wysocki
On Wednesday 24 of October 2012 08:47:52 Ondrej Zary wrote: Some MSI laptop BIOSes are broken - INT 15h code uses port 92h to enable A20 line but resume code assumes that KBC was used. The laptop will not resume from S3 otherwise but powers off after a while and then powers on again stuck with

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-24 Thread H. Peter Anvin
Minor concern: it should do the wait for ready before sending each command. Rafael J. Wysocki r...@sisk.pl wrote: On Wednesday 24 of October 2012 08:47:52 Ondrej Zary wrote: Some MSI laptop BIOSes are broken - INT 15h code uses port 92h to enable A20 line but resume code assumes that KBC was

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-24 Thread Ondrej Zary
On Wednesday 24 October 2012 21:36:04 H. Peter Anvin wrote: Minor concern: it should do the wait for ready before sending each command. It was a hack and then I forgot to add the waits... Should I redo the patch? I'll not be able to test it as I have to return the machine. Rafael J. Wysocki

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-24 Thread H. Peter Anvin
Probably should. Ondrej Zary li...@rainbow-software.org wrote: On Wednesday 24 October 2012 21:36:04 H. Peter Anvin wrote: Minor concern: it should do the wait for ready before sending each command. It was a hack and then I forgot to add the waits... Should I redo the patch? I'll not be able

Re: [PATCH] Enable A20 using KBC for some MSI laptops to fix S3 resume

2012-10-24 Thread Alan Cox
On Wed, 24 Oct 2012 12:36:04 -0700 H. Peter Anvin h...@zytor.com wrote: Minor concern: it should do the wait for ready before sending each command. Can we get a command line to do this quirk too - it strikes me that if the MSIs rely upon it then it may be something Windows always does so will