Re: [PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-18 Thread Stephen C. Tweedie
Hi, On Mon, 2007-09-17 at 11:06 -0500, Eric Sandeen wrote: > The do_split() function for htree dir blocks is intended to split a > leaf block to make room for a new entry. It sorts the entries in the > original block by hash value, then moves the last half of the entries to > the new block -

Re: [PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-18 Thread Stephen C. Tweedie
Hi, On Mon, 2007-09-17 at 11:06 -0500, Eric Sandeen wrote: The do_split() function for htree dir blocks is intended to split a leaf block to make room for a new entry. It sorts the entries in the original block by hash value, then moves the last half of the entries to the new block -

Re: [PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-17 Thread hooanon05
Andreas Dilger: > > So this looks like 2.6.22 and 2.6.23 material, but the timing is getting > > pretty squeezy. Could people please give this change an extra-close > > review, let me know? > > I already discussed it at length with Eric and inspected the patch, so we > could add: >

Re: [PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-17 Thread Andreas Dilger
On Sep 17, 2007 13:30 -0700, Andrew Morton wrote: > On Mon, 17 Sep 2007 12:21:40 -0500 > > Eric Sandeen wrote: > > > The do_split() function for htree dir blocks is intended to split a > > > leaf block to make room for a new entry. It sorts the entries in the > > > original block by hash value,

Re: [PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-17 Thread Andrew Morton
On Mon, 17 Sep 2007 12:21:40 -0500 Eric Sandeen <[EMAIL PROTECTED]> wrote: > Eric Sandeen wrote: > > The do_split() function for htree dir blocks is intended to split a > > leaf block to make room for a new entry. It sorts the entries in the > > original block by hash value, then moves the last

Re: [PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-17 Thread Eric Sandeen
Eric Sandeen wrote: > The do_split() function for htree dir blocks is intended to split a > leaf block to make room for a new entry. It sorts the entries in the > original block by hash value, then moves the last half of the entries to > the new block - without accounting for how much space this

[PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-17 Thread Eric Sandeen
The do_split() function for htree dir blocks is intended to split a leaf block to make room for a new entry. It sorts the entries in the original block by hash value, then moves the last half of the entries to the new block - without accounting for how much space this actually moves. (IOW, it

[PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-17 Thread Eric Sandeen
The do_split() function for htree dir blocks is intended to split a leaf block to make room for a new entry. It sorts the entries in the original block by hash value, then moves the last half of the entries to the new block - without accounting for how much space this actually moves. (IOW, it

Re: [PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-17 Thread Eric Sandeen
Eric Sandeen wrote: The do_split() function for htree dir blocks is intended to split a leaf block to make room for a new entry. It sorts the entries in the original block by hash value, then moves the last half of the entries to the new block - without accounting for how much space this

Re: [PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-17 Thread Andrew Morton
On Mon, 17 Sep 2007 12:21:40 -0500 Eric Sandeen [EMAIL PROTECTED] wrote: Eric Sandeen wrote: The do_split() function for htree dir blocks is intended to split a leaf block to make room for a new entry. It sorts the entries in the original block by hash value, then moves the last half of

Re: [PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-17 Thread Andreas Dilger
On Sep 17, 2007 13:30 -0700, Andrew Morton wrote: On Mon, 17 Sep 2007 12:21:40 -0500 Eric Sandeen wrote: The do_split() function for htree dir blocks is intended to split a leaf block to make room for a new entry. It sorts the entries in the original block by hash value, then moves

Re: [PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-17 Thread hooanon05
Andreas Dilger: So this looks like 2.6.22 and 2.6.23 material, but the timing is getting pretty squeezy. Could people please give this change an extra-close review, let me know? I already discussed it at length with Eric and inspected the patch, so we could add: Signed-off-by: Andreas