Re: [PATCH] ext4: fix ext4_count_free_clusters() with EXT4FS_DEBUG and bigalloc enabled

2014-04-14 Thread Theodore Ts'o
On Mon, Apr 14, 2014 at 08:18:36PM +0400, Azat Khuzhin wrote: > With bigalloc enabled we must use EXT4_CLUSTERS_PER_GROUP() instead of > EXT4_BLOCKS_PER_GROUP() otherwise we will go beyond the allocated buffer. You forgot the signed-off-by, since it's a one-line patch, I'll apply it. Thanks!

[PATCH] ext4: fix ext4_count_free_clusters() with EXT4FS_DEBUG and bigalloc enabled

2014-04-14 Thread Azat Khuzhin
With bigalloc enabled we must use EXT4_CLUSTERS_PER_GROUP() instead of EXT4_BLOCKS_PER_GROUP() otherwise we will go beyond the allocated buffer. $ mount -t ext4 /dev/vde /vde [ 70.573993] EXT4-fs DEBUG (fs/ext4/mballoc.c, 2346): ext4_mb_alloc_groupinfo: [ 70.575174] allocated s_groupinfo

Re: [PATCH] ext4: fix ext4_count_free_clusters() with EXT4FS_DEBUG and bigalloc enabled

2014-04-14 Thread Theodore Ts'o
On Mon, Apr 14, 2014 at 08:18:36PM +0400, Azat Khuzhin wrote: With bigalloc enabled we must use EXT4_CLUSTERS_PER_GROUP() instead of EXT4_BLOCKS_PER_GROUP() otherwise we will go beyond the allocated buffer. You forgot the signed-off-by, since it's a one-line patch, I'll apply it. Thanks!

[PATCH] ext4: fix ext4_count_free_clusters() with EXT4FS_DEBUG and bigalloc enabled

2014-04-14 Thread Azat Khuzhin
With bigalloc enabled we must use EXT4_CLUSTERS_PER_GROUP() instead of EXT4_BLOCKS_PER_GROUP() otherwise we will go beyond the allocated buffer. $ mount -t ext4 /dev/vde /vde [ 70.573993] EXT4-fs DEBUG (fs/ext4/mballoc.c, 2346): ext4_mb_alloc_groupinfo: [ 70.575174] allocated s_groupinfo