Re: [PATCH] firmware: gsmi: Drop the use of dma_pool_* API functions

2020-10-21 Thread Furquan Shaikh
On Wed, Oct 21, 2020 at 2:36 AM Ard Biesheuvel wrote: > > On Wed, 21 Oct 2020 at 10:51, Greg Kroah-Hartman > wrote: > > > > On Wed, Oct 21, 2020 at 12:37:52AM -0700, Furquan Shaikh wrote: > > > On Tue, Oct 20, 2020 at 11:37 PM Ard Biesheuvel wrote: > > > > > > > > On Wed, 21 Oct 2020 at 07:18,

Re: [PATCH] firmware: gsmi: Drop the use of dma_pool_* API functions

2020-10-21 Thread Ard Biesheuvel
On Wed, 21 Oct 2020 at 10:51, Greg Kroah-Hartman wrote: > > On Wed, Oct 21, 2020 at 12:37:52AM -0700, Furquan Shaikh wrote: > > On Tue, Oct 20, 2020 at 11:37 PM Ard Biesheuvel wrote: > > > > > > On Wed, 21 Oct 2020 at 07:18, Greg Kroah-Hartman > > > wrote: > > > > > > > > On Tue, Oct 20, 2020

Re: [PATCH] firmware: gsmi: Drop the use of dma_pool_* API functions

2020-10-21 Thread Greg Kroah-Hartman
On Wed, Oct 21, 2020 at 12:37:52AM -0700, Furquan Shaikh wrote: > On Tue, Oct 20, 2020 at 11:37 PM Ard Biesheuvel wrote: > > > > On Wed, 21 Oct 2020 at 07:18, Greg Kroah-Hartman > > wrote: > > > > > > On Tue, Oct 20, 2020 at 10:01:41PM -0700, Furquan Shaikh wrote: > > > > GSMI driver uses

Re: [PATCH] firmware: gsmi: Drop the use of dma_pool_* API functions

2020-10-21 Thread kernel test robot
Hi Furquan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on linux/master v5.9 next-20201021] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base'

Re: [PATCH] firmware: gsmi: Drop the use of dma_pool_* API functions

2020-10-21 Thread Furquan Shaikh
On Tue, Oct 20, 2020 at 11:37 PM Ard Biesheuvel wrote: > > On Wed, 21 Oct 2020 at 07:18, Greg Kroah-Hartman > wrote: > > > > On Tue, Oct 20, 2020 at 10:01:41PM -0700, Furquan Shaikh wrote: > > > GSMI driver uses dma_pool_* API functions for buffer allocation > > > because it requires that the

Re: [PATCH] firmware: gsmi: Drop the use of dma_pool_* API functions

2020-10-21 Thread Ard Biesheuvel
On Wed, 21 Oct 2020 at 07:18, Greg Kroah-Hartman wrote: > > On Tue, Oct 20, 2020 at 10:01:41PM -0700, Furquan Shaikh wrote: > > GSMI driver uses dma_pool_* API functions for buffer allocation > > because it requires that the SMI buffers are allocated within 32-bit > > physical address space.

Re: [PATCH] firmware: gsmi: Drop the use of dma_pool_* API functions

2020-10-20 Thread Greg Kroah-Hartman
On Tue, Oct 20, 2020 at 10:01:41PM -0700, Furquan Shaikh wrote: > GSMI driver uses dma_pool_* API functions for buffer allocation > because it requires that the SMI buffers are allocated within 32-bit > physical address space. However, this does not work well with IOMMU > since there is no real

[PATCH] firmware: gsmi: Drop the use of dma_pool_* API functions

2020-10-20 Thread Furquan Shaikh
GSMI driver uses dma_pool_* API functions for buffer allocation because it requires that the SMI buffers are allocated within 32-bit physical address space. However, this does not work well with IOMMU since there is no real device and hence no domain associated with the device. Since this is not