Re: [PATCH] hwrng: ingenic - Fix a resource leak in an error handling path

2021-01-02 Thread Herbert Xu
On Sat, Dec 19, 2020 at 08:52:07AM +0100, Christophe JAILLET wrote: > In case of error, we should call 'clk_disable_unprepare()' to undo a > previous 'clk_prepare_enable()' call, as already done in the remove > function. > > Fixes: 406346d22278 ("hwrng: ingenic - Add hardware TRNG for Ingenic

Re: [PATCH] hwrng: ingenic - Fix a resource leak in an error handling path

2020-12-20 Thread Zhou Yanjie
Hi Christophe, On 2020/12/19 下午3:52, Christophe JAILLET wrote: In case of error, we should call 'clk_disable_unprepare()' to undo a previous 'clk_prepare_enable()' call, as already done in the remove function. Fixes: 406346d22278 ("hwrng: ingenic - Add hardware TRNG for Ingenic X1830")

[PATCH] hwrng: ingenic - Fix a resource leak in an error handling path

2020-12-18 Thread Christophe JAILLET
In case of error, we should call 'clk_disable_unprepare()' to undo a previous 'clk_prepare_enable()' call, as already done in the remove function. Fixes: 406346d22278 ("hwrng: ingenic - Add hardware TRNG for Ingenic X1830") Signed-off-by: Christophe JAILLET ---