Re: [PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-12 Thread Andy Shevchenko
On Mon, Jun 12, 2017 at 1:19 PM, Peter Rosin wrote: > On 2017-06-12 11:38, Andy Shevchenko wrote: >> On Mon, Jun 12, 2017 at 12:28 PM, Peter Rosin wrote: >>> On 2017-06-12 11:11, Andy Shevchenko wrote: On Mon, Jun 12, 2017 at 6:42 AM, Song liwei

Re: [PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-12 Thread Andy Shevchenko
On Mon, Jun 12, 2017 at 1:19 PM, Peter Rosin wrote: > On 2017-06-12 11:38, Andy Shevchenko wrote: >> On Mon, Jun 12, 2017 at 12:28 PM, Peter Rosin wrote: >>> On 2017-06-12 11:11, Andy Shevchenko wrote: On Mon, Jun 12, 2017 at 6:42 AM, Song liwei wrote: > From: Liwei Song >>

Re: [PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-12 Thread Peter Rosin
On 2017-06-12 11:38, Andy Shevchenko wrote: > On Mon, Jun 12, 2017 at 12:28 PM, Peter Rosin wrote: >> On 2017-06-12 11:11, Andy Shevchenko wrote: >>> On Mon, Jun 12, 2017 at 6:42 AM, Song liwei >>> wrote: From: Liwei Song

Re: [PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-12 Thread Peter Rosin
On 2017-06-12 11:38, Andy Shevchenko wrote: > On Mon, Jun 12, 2017 at 12:28 PM, Peter Rosin wrote: >> On 2017-06-12 11:11, Andy Shevchenko wrote: >>> On Mon, Jun 12, 2017 at 6:42 AM, Song liwei >>> wrote: From: Liwei Song > After finished I2C block read/write, when unmap the data

Re: [PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-12 Thread Andy Shevchenko
On Mon, Jun 12, 2017 at 6:42 AM, Song liwei wrote: > From: Liwei Song Btw, it seems it has to include Fixes tag. > Signed-off-by: Liwei Song > --- > drivers/i2c/busses/i2c-ismt.c | 2 +- > 1 file changed, 1

Re: [PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-12 Thread Andy Shevchenko
On Mon, Jun 12, 2017 at 6:42 AM, Song liwei wrote: > From: Liwei Song Btw, it seems it has to include Fixes tag. > Signed-off-by: Liwei Song > --- > drivers/i2c/busses/i2c-ismt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-ismt.c

Re: [PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-12 Thread Andy Shevchenko
On Mon, Jun 12, 2017 at 12:28 PM, Peter Rosin wrote: > On 2017-06-12 11:11, Andy Shevchenko wrote: >> On Mon, Jun 12, 2017 at 6:42 AM, Song liwei wrote: >>> From: Liwei Song >>> After finished I2C block read/write, when unmap

Re: [PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-12 Thread Andy Shevchenko
On Mon, Jun 12, 2017 at 12:28 PM, Peter Rosin wrote: > On 2017-06-12 11:11, Andy Shevchenko wrote: >> On Mon, Jun 12, 2017 at 6:42 AM, Song liwei wrote: >>> From: Liwei Song >>> After finished I2C block read/write, when unmap the data buffer, >>> a wrong device address was pass to

Re: [PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-12 Thread Peter Rosin
On 2017-06-12 11:11, Andy Shevchenko wrote: > On Mon, Jun 12, 2017 at 6:42 AM, Song liwei wrote: >> From: Liwei Song >> > >> Fix the following calltrace: > > No, you don't fix a call trace, you are fixing a bug. > >> This happen When run

Re: [PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-12 Thread Peter Rosin
On 2017-06-12 11:11, Andy Shevchenko wrote: > On Mon, Jun 12, 2017 at 6:42 AM, Song liwei wrote: >> From: Liwei Song >> > >> Fix the following calltrace: > > No, you don't fix a call trace, you are fixing a bug. > >> This happen When run "i2cdetect -y 0" detect SMBus iSMT adapter. >> >> After

Re: [PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-12 Thread Andy Shevchenko
On Mon, Jun 12, 2017 at 6:42 AM, Song liwei wrote: > From: Liwei Song > > Fix the following calltrace: No, you don't fix a call trace, you are fixing a bug. > This happen When run "i2cdetect -y 0" detect SMBus iSMT adapter. > > After

Re: [PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-12 Thread Andy Shevchenko
On Mon, Jun 12, 2017 at 6:42 AM, Song liwei wrote: > From: Liwei Song > > Fix the following calltrace: No, you don't fix a call trace, you are fixing a bug. > This happen When run "i2cdetect -y 0" detect SMBus iSMT adapter. > > After finished I2C block read/write, when unmap the data buffer,

[PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-11 Thread Song liwei
From: Liwei Song Fix the following calltrace: kernel BUG at drivers/iommu/intel-iommu.c:3260! invalid opcode: [#5] PREEMPT SMP Hardware name: Intel Corp. Harcuvar/Server, BIOS HAVLCRB0.X64.0013.D39.1608311820 08/31/2016 task: 880175389950 ti: 880176bec000

[PATCH] i2c: ismt: fix wrong device address when unmap the data buffer

2017-06-11 Thread Song liwei
From: Liwei Song Fix the following calltrace: kernel BUG at drivers/iommu/intel-iommu.c:3260! invalid opcode: [#5] PREEMPT SMP Hardware name: Intel Corp. Harcuvar/Server, BIOS HAVLCRB0.X64.0013.D39.1608311820 08/31/2016 task: 880175389950 ti: 880176bec000 task.ti: 880176bec000