Re: [PATCH] input: joystick: make USB drivers depend on USB

2018-01-18 Thread Dmitry Torokhov
On Thu, Jan 18, 2018 at 10:25:21AM -0800, Randy Dunlap wrote: > On 01/17/2018 01:53 PM, Dmitry Torokhov wrote: > > On Wed, Jan 17, 2018 at 10:30:10PM +0100, Marcus Folkesson wrote: > >> A driver should not enable an entire subsystem. > > > > I disagree. As you go through menuconfig and you

Re: [PATCH] input: joystick: make USB drivers depend on USB

2018-01-18 Thread Dmitry Torokhov
On Thu, Jan 18, 2018 at 10:25:21AM -0800, Randy Dunlap wrote: > On 01/17/2018 01:53 PM, Dmitry Torokhov wrote: > > On Wed, Jan 17, 2018 at 10:30:10PM +0100, Marcus Folkesson wrote: > >> A driver should not enable an entire subsystem. > > > > I disagree. As you go through menuconfig and you

Re: [PATCH] input: joystick: make USB drivers depend on USB

2018-01-18 Thread Randy Dunlap
On 01/17/2018 01:53 PM, Dmitry Torokhov wrote: > On Wed, Jan 17, 2018 at 10:30:10PM +0100, Marcus Folkesson wrote: >> A driver should not enable an entire subsystem. > > I disagree. As you go through menuconfig and you encounter this option > and you have the hardware and you want to enable it,

Re: [PATCH] input: joystick: make USB drivers depend on USB

2018-01-18 Thread Randy Dunlap
On 01/17/2018 01:53 PM, Dmitry Torokhov wrote: > On Wed, Jan 17, 2018 at 10:30:10PM +0100, Marcus Folkesson wrote: >> A driver should not enable an entire subsystem. > > I disagree. As you go through menuconfig and you encounter this option > and you have the hardware and you want to enable it,

Re: [PATCH] input: joystick: make USB drivers depend on USB

2018-01-17 Thread Randy Dunlap
On 01/17/2018 01:53 PM, Dmitry Torokhov wrote: > On Wed, Jan 17, 2018 at 10:30:10PM +0100, Marcus Folkesson wrote: >> A driver should not enable an entire subsystem. > > I disagree. As you go through menuconfig and you encounter this option > and you have the hardware and you want to enable it,

Re: [PATCH] input: joystick: make USB drivers depend on USB

2018-01-17 Thread Randy Dunlap
On 01/17/2018 01:53 PM, Dmitry Torokhov wrote: > On Wed, Jan 17, 2018 at 10:30:10PM +0100, Marcus Folkesson wrote: >> A driver should not enable an entire subsystem. > > I disagree. As you go through menuconfig and you encounter this option > and you have the hardware and you want to enable it,

Re: [PATCH] input: joystick: make USB drivers depend on USB

2018-01-17 Thread Dmitry Torokhov
On Wed, Jan 17, 2018 at 10:30:10PM +0100, Marcus Folkesson wrote: > A driver should not enable an entire subsystem. I disagree. As you go through menuconfig and you encounter this option and you have the hardware and you want to enable it, you should be able to do so. Otherwise you enable bunch

Re: [PATCH] input: joystick: make USB drivers depend on USB

2018-01-17 Thread Dmitry Torokhov
On Wed, Jan 17, 2018 at 10:30:10PM +0100, Marcus Folkesson wrote: > A driver should not enable an entire subsystem. I disagree. As you go through menuconfig and you encounter this option and you have the hardware and you want to enable it, you should be able to do so. Otherwise you enable bunch

[PATCH] input: joystick: make USB drivers depend on USB

2018-01-17 Thread Marcus Folkesson
A driver should not enable an entire subsystem. Signed-off-by: Marcus Folkesson --- drivers/input/joystick/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig index

[PATCH] input: joystick: make USB drivers depend on USB

2018-01-17 Thread Marcus Folkesson
A driver should not enable an entire subsystem. Signed-off-by: Marcus Folkesson --- drivers/input/joystick/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig index 332c0cc1b2ab..4a199cff8c68 100644 ---