Re: [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove

2017-06-12 Thread jeffy
Hi Lee, On 06/12/2017 04:17 PM, Lee Jones wrote: mfd: cros_ec: Add missing free_irq in cros_ec_remove It would be better to use more English and less code in the patch's subject line. Something like "Clean-up IRQ on unbind" Or "Free IRQ on exit". Something of that nature. Also, you should

Re: [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove

2017-06-12 Thread jeffy
Hi Lee, On 06/12/2017 04:17 PM, Lee Jones wrote: mfd: cros_ec: Add missing free_irq in cros_ec_remove It would be better to use more English and less code in the patch's subject line. Something like "Clean-up IRQ on unbind" Or "Free IRQ on exit". Something of that nature. Also, you should

Re: [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove

2017-06-12 Thread Lee Jones
mfd: cros_ec: Add missing free_irq in cros_ec_remove It would be better to use more English and less code in the patch's subject line. Something like "Clean-up IRQ on unbind" Or "Free IRQ on exit". Something of that nature. Also, you should populate the commit log with what are you doing and

Re: [PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove

2017-06-12 Thread Lee Jones
mfd: cros_ec: Add missing free_irq in cros_ec_remove It would be better to use more English and less code in the patch's subject line. Something like "Clean-up IRQ on unbind" Or "Free IRQ on exit". Something of that nature. Also, you should populate the commit log with what are you doing and

[PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove

2017-06-11 Thread Jeffy Chen
Signed-off-by: Jeffy Chen --- drivers/mfd/cros_ec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c index e31ac60..dc6ce90 100644 --- a/drivers/mfd/cros_ec.c +++ b/drivers/mfd/cros_ec.c @@ -183,6 +183,9 @@ int

[PATCH] mfd: cros_ec: Add missing free_irq in cros_ec_remove

2017-06-11 Thread Jeffy Chen
Signed-off-by: Jeffy Chen --- drivers/mfd/cros_ec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c index e31ac60..dc6ce90 100644 --- a/drivers/mfd/cros_ec.c +++ b/drivers/mfd/cros_ec.c @@ -183,6 +183,9 @@ int cros_ec_remove(struct