Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-04-02 Thread Andrea Arcangeli
Hi, On Wed, Apr 02, 2014 at 11:18:27AM -0400, Jerome Glisse wrote: > This would imply either to scan all mmu_notifier currently register or to > have a global flags for the mm to know if there is one mmu_notifier without > change_pte. Moreover this would means that kvm would remain "broken" if

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-04-02 Thread Jerome Glisse
On Wed, Apr 02, 2014 at 03:52:45PM +0300, Haggai Eran wrote: > On 03/30/2014 11:33 PM, Jerome Glisse wrote: > >On Wed, Jan 22, 2014 at 04:01:15PM +0200, Haggai Eran wrote: > >>I'm worried about the following scenario: > >> > >>Given a read-only page, suppose one host thread (thread 1) writes to >

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-04-02 Thread Haggai Eran
On 03/30/2014 11:33 PM, Jerome Glisse wrote: On Wed, Jan 22, 2014 at 04:01:15PM +0200, Haggai Eran wrote: I'm worried about the following scenario: Given a read-only page, suppose one host thread (thread 1) writes to that page, and performs COW, but before it calls the

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-04-02 Thread Haggai Eran
On 03/30/2014 11:33 PM, Jerome Glisse wrote: On Wed, Jan 22, 2014 at 04:01:15PM +0200, Haggai Eran wrote: I'm worried about the following scenario: Given a read-only page, suppose one host thread (thread 1) writes to that page, and performs COW, but before it calls the

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-04-02 Thread Jerome Glisse
On Wed, Apr 02, 2014 at 03:52:45PM +0300, Haggai Eran wrote: On 03/30/2014 11:33 PM, Jerome Glisse wrote: On Wed, Jan 22, 2014 at 04:01:15PM +0200, Haggai Eran wrote: I'm worried about the following scenario: Given a read-only page, suppose one host thread (thread 1) writes to that page,

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-04-02 Thread Andrea Arcangeli
Hi, On Wed, Apr 02, 2014 at 11:18:27AM -0400, Jerome Glisse wrote: This would imply either to scan all mmu_notifier currently register or to have a global flags for the mm to know if there is one mmu_notifier without change_pte. Moreover this would means that kvm would remain broken if one of

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-03-30 Thread Jerome Glisse
On Wed, Jan 22, 2014 at 04:01:15PM +0200, Haggai Eran wrote: > On 22/01/2014 15:10, Andrea Arcangeli wrote: > > On Wed, Jan 15, 2014 at 11:40:34AM +0200, Mike Rapoport wrote: > >> Commit 6bdb913f0a70a4dfb7f066fb15e2d6f960701d00 (mm: wrap calls to > >> set_pte_at_notify with invalidate_range_start

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-03-30 Thread Jerome Glisse
On Wed, Jan 22, 2014 at 04:01:15PM +0200, Haggai Eran wrote: On 22/01/2014 15:10, Andrea Arcangeli wrote: On Wed, Jan 15, 2014 at 11:40:34AM +0200, Mike Rapoport wrote: Commit 6bdb913f0a70a4dfb7f066fb15e2d6f960701d00 (mm: wrap calls to set_pte_at_notify with invalidate_range_start and

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-01-22 Thread Andrea Arcangeli
On Wed, Jan 22, 2014 at 01:54:59PM -0800, Andrew Morton wrote: > The changelog fails to describe the end-user visible effects of the > bug, so I (and others) will be unable to decide which kernel versions > need patching > > Given that the bug has been around for 1.5 years I assume the priority >

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-01-22 Thread Andrew Morton
On Wed, 15 Jan 2014 11:40:34 +0200 Mike Rapoport wrote: > Commit 6bdb913f0a70a4dfb7f066fb15e2d6f960701d00 (mm: wrap calls to > set_pte_at_notify with invalidate_range_start and invalidate_range_end) > breaks semantics of set_pte_at_notify. When calls to set_pte_at_notify > are wrapped with

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-01-22 Thread Haggai Eran
On 22/01/2014 15:10, Andrea Arcangeli wrote: > On Wed, Jan 15, 2014 at 11:40:34AM +0200, Mike Rapoport wrote: >> Commit 6bdb913f0a70a4dfb7f066fb15e2d6f960701d00 (mm: wrap calls to >> set_pte_at_notify with invalidate_range_start and invalidate_range_end) >> breaks semantics of set_pte_at_notify.

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-01-22 Thread Andrea Arcangeli
On Wed, Jan 15, 2014 at 11:40:34AM +0200, Mike Rapoport wrote: > Commit 6bdb913f0a70a4dfb7f066fb15e2d6f960701d00 (mm: wrap calls to > set_pte_at_notify with invalidate_range_start and invalidate_range_end) > breaks semantics of set_pte_at_notify. When calls to set_pte_at_notify > are wrapped with

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-01-22 Thread Andrea Arcangeli
On Wed, Jan 15, 2014 at 11:40:34AM +0200, Mike Rapoport wrote: Commit 6bdb913f0a70a4dfb7f066fb15e2d6f960701d00 (mm: wrap calls to set_pte_at_notify with invalidate_range_start and invalidate_range_end) breaks semantics of set_pte_at_notify. When calls to set_pte_at_notify are wrapped with

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-01-22 Thread Haggai Eran
On 22/01/2014 15:10, Andrea Arcangeli wrote: On Wed, Jan 15, 2014 at 11:40:34AM +0200, Mike Rapoport wrote: Commit 6bdb913f0a70a4dfb7f066fb15e2d6f960701d00 (mm: wrap calls to set_pte_at_notify with invalidate_range_start and invalidate_range_end) breaks semantics of set_pte_at_notify. When

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-01-22 Thread Andrew Morton
On Wed, 15 Jan 2014 11:40:34 +0200 Mike Rapoport mike.rapop...@ravellosystems.com wrote: Commit 6bdb913f0a70a4dfb7f066fb15e2d6f960701d00 (mm: wrap calls to set_pte_at_notify with invalidate_range_start and invalidate_range_end) breaks semantics of set_pte_at_notify. When calls to

Re: [PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-01-22 Thread Andrea Arcangeli
On Wed, Jan 22, 2014 at 01:54:59PM -0800, Andrew Morton wrote: The changelog fails to describe the end-user visible effects of the bug, so I (and others) will be unable to decide which kernel versions need patching Given that the bug has been around for 1.5 years I assume the priority is

[PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-01-15 Thread Mike Rapoport
Commit 6bdb913f0a70a4dfb7f066fb15e2d6f960701d00 (mm: wrap calls to set_pte_at_notify with invalidate_range_start and invalidate_range_end) breaks semantics of set_pte_at_notify. When calls to set_pte_at_notify are wrapped with mmu_notifier_invalidate_range_start and

[PATCH] mm/mmu_notifier: restore set_pte_at_notify semantics

2014-01-15 Thread Mike Rapoport
Commit 6bdb913f0a70a4dfb7f066fb15e2d6f960701d00 (mm: wrap calls to set_pte_at_notify with invalidate_range_start and invalidate_range_end) breaks semantics of set_pte_at_notify. When calls to set_pte_at_notify are wrapped with mmu_notifier_invalidate_range_start and