Re: [PATCH] mmc: sdhci-sprd: Fix some resource leaks in the remove function

2021-01-11 Thread Ulf Hansson
On Thu, 17 Dec 2020 at 21:42, Christophe JAILLET wrote: > > 'sdhci_remove_host()' and 'sdhci_pltfm_free()' should be used in place of > 'mmc_remove_host()' and 'mmc_free_host()'. > > This avoids some resource leaks, is more in line with the error handling > path of the probe function, and is more

Re: [PATCH] mmc: sdhci-sprd: Fix some resource leaks in the remove function

2021-01-05 Thread Adrian Hunter
On 17/12/20 10:42 pm, Christophe JAILLET wrote: > 'sdhci_remove_host()' and 'sdhci_pltfm_free()' should be used in place of > 'mmc_remove_host()' and 'mmc_free_host()'. > > This avoids some resource leaks, is more in line with the error handling > path of the probe function, and is more

Re: [PATCH] mmc: sdhci-sprd: Fix some resource leaks in the remove function

2020-12-19 Thread Orson Zhai
On Fri, Dec 18, 2020 at 9:46 PM Christophe JAILLET wrote: > > Le 17/12/2020 à 23:55, Orson Zhai a écrit : > > + cc: Billows > > > > Hi Christophe, > > On Fri, Dec 18, 2020 at 4:50 AM Christophe JAILLET > > wrote: > >> > >> 'sdhci_remove_host()' and 'sdhci_pltfm_free()' should be used in place of

Re: [PATCH] mmc: sdhci-sprd: Fix some resource leaks in the remove function

2020-12-18 Thread Christophe JAILLET
Le 17/12/2020 à 23:55, Orson Zhai a écrit : + cc: Billows Hi Christophe, On Fri, Dec 18, 2020 at 4:50 AM Christophe JAILLET wrote: 'sdhci_remove_host()' and 'sdhci_pltfm_free()' should be used in place of 'mmc_remove_host()' and 'mmc_free_host()'. This avoids some resource leaks, is more in

Re: [PATCH] mmc: sdhci-sprd: Fix some resource leaks in the remove function

2020-12-17 Thread Orson Zhai
+ cc: Billows Hi Christophe, On Fri, Dec 18, 2020 at 4:50 AM Christophe JAILLET wrote: > > 'sdhci_remove_host()' and 'sdhci_pltfm_free()' should be used in place of > 'mmc_remove_host()' and 'mmc_free_host()'. > > This avoids some resource leaks, is more in line with the error handling > path of

[PATCH] mmc: sdhci-sprd: Fix some resource leaks in the remove function

2020-12-17 Thread Christophe JAILLET
'sdhci_remove_host()' and 'sdhci_pltfm_free()' should be used in place of 'mmc_remove_host()' and 'mmc_free_host()'. This avoids some resource leaks, is more in line with the error handling path of the probe function, and is more consistent with other drivers. Fixes: fb8bd90f83c4 ("mmc: