Re: [PATCH] modules: add support for soft module dependencies

2013-09-18 Thread Rusty Russell
Lucas De Marchi writes: > On Tue, Sep 17, 2013 at 11:10 PM, Rusty Russell wrote: >> Lucas De Marchi writes: >>> On Thu, Sep 12, 2013 at 9:07 PM, Rusty Russell >>> wrote: I'm happy to change this macro to create a modinfo line like "softdep:" >>> >>> how is that solving the issue

Re: [PATCH] modules: add support for soft module dependencies

2013-09-18 Thread Rusty Russell
Lucas De Marchi lucas.demar...@profusion.mobi writes: On Tue, Sep 17, 2013 at 11:10 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Thu, Sep 12, 2013 at 9:07 PM, Rusty Russell ru...@rustcorp.com.au wrote: I'm happy to change this macro to

Re: [PATCH] modules: add support for soft module dependencies

2013-09-17 Thread Lucas De Marchi
On Tue, Sep 17, 2013 at 11:10 PM, Rusty Russell wrote: > Lucas De Marchi writes: >> On Thu, Sep 12, 2013 at 9:07 PM, Rusty Russell wrote: >>> Lucas De Marchi writes: On Wed, Jul 24, 2013 at 11:03 PM, Herbert Xu wrote: > On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell

Re: [PATCH] modules: add support for soft module dependencies

2013-09-17 Thread Rusty Russell
Lucas De Marchi writes: > On Thu, Sep 12, 2013 at 9:07 PM, Rusty Russell wrote: >> Lucas De Marchi writes: >>> On Wed, Jul 24, 2013 at 11:03 PM, Herbert Xu >>> wrote: On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell wrote: > Herbert Xu writes: > > Hi Rusty: > > > >

Re: [PATCH] modules: add support for soft module dependencies

2013-09-17 Thread Lucas De Marchi
On Thu, Sep 12, 2013 at 9:07 PM, Rusty Russell wrote: > Lucas De Marchi writes: >> On Wed, Jul 24, 2013 at 11:03 PM, Herbert Xu >> wrote: >>> On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell wrote: Herbert Xu writes: > Hi Rusty: > > I don't know why this patch never

Re: [PATCH] modules: add support for soft module dependencies

2013-09-17 Thread Lucas De Marchi
On Thu, Sep 12, 2013 at 9:07 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Wed, Jul 24, 2013 at 11:03 PM, Herbert Xu herb...@gondor.apana.org.au wrote: On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell wrote: Herbert Xu

Re: [PATCH] modules: add support for soft module dependencies

2013-09-17 Thread Rusty Russell
Lucas De Marchi lucas.de.mar...@gmail.com writes: On Thu, Sep 12, 2013 at 9:07 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Wed, Jul 24, 2013 at 11:03 PM, Herbert Xu herb...@gondor.apana.org.au wrote: On Thu, Jul 25, 2013 at 09:32:02AM

Re: [PATCH] modules: add support for soft module dependencies

2013-09-17 Thread Lucas De Marchi
On Tue, Sep 17, 2013 at 11:10 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Thu, Sep 12, 2013 at 9:07 PM, Rusty Russell ru...@rustcorp.com.au wrote: Lucas De Marchi lucas.de.mar...@gmail.com writes: On Wed, Jul 24, 2013 at 11:03 PM, Herbert

Re: [PATCH] modules: add support for soft module dependencies

2013-09-12 Thread Rusty Russell
Lucas De Marchi writes: > On Wed, Jul 24, 2013 at 11:03 PM, Herbert Xu > wrote: >> On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell wrote: >>> Herbert Xu writes: >>> > Hi Rusty: >>> > >>> > I don't know why this patch never went into the kernel, even >>> > though the corresponding

Re: [PATCH] modules: add support for soft module dependencies

2013-09-12 Thread Rusty Russell
Lucas De Marchi lucas.de.mar...@gmail.com writes: On Wed, Jul 24, 2013 at 11:03 PM, Herbert Xu herb...@gondor.apana.org.au wrote: On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell wrote: Herbert Xu herb...@gondor.apana.org.au writes: Hi Rusty: I don't know why this patch never went

Re: [PATCH] modules: add support for soft module dependencies

2013-09-10 Thread Herbert Xu
On Tue, Sep 10, 2013 at 11:01:38AM -0300, Lucas De Marchi wrote: > > However looking at the only user right now, crct10dif: couldn't we > detect at runtime if this module can be used instead of just trying to > load it as a pre softdep and possibly failing? No as sd_mod requires crct10dif to be

Re: [PATCH] modules: add support for soft module dependencies

2013-09-10 Thread Tom Gundersen
On Tue, Sep 10, 2013 at 4:01 PM, Lucas De Marchi wrote: > On Wed, Jul 24, 2013 at 11:03 PM, Herbert Xu > wrote: >> On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell wrote: >>> Herbert Xu writes: >>> > Hi Rusty: >>> > >>> > I don't know why this patch never went into the kernel, even >>> >

Re: [PATCH] modules: add support for soft module dependencies

2013-09-10 Thread Lucas De Marchi
On Wed, Jul 24, 2013 at 11:03 PM, Herbert Xu wrote: > On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell wrote: >> Herbert Xu writes: >> > Hi Rusty: >> > >> > I don't know why this patch never went into the kernel, even >> > though the corresponding features have been added to modprobe >> >

Re: [PATCH] modules: add support for soft module dependencies

2013-09-10 Thread Lucas De Marchi
On Wed, Jul 24, 2013 at 11:03 PM, Herbert Xu herb...@gondor.apana.org.au wrote: On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell wrote: Herbert Xu herb...@gondor.apana.org.au writes: Hi Rusty: I don't know why this patch never went into the kernel, even though the corresponding

Re: [PATCH] modules: add support for soft module dependencies

2013-09-10 Thread Tom Gundersen
On Tue, Sep 10, 2013 at 4:01 PM, Lucas De Marchi lucas.de.mar...@gmail.com wrote: On Wed, Jul 24, 2013 at 11:03 PM, Herbert Xu herb...@gondor.apana.org.au wrote: On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell wrote: Herbert Xu herb...@gondor.apana.org.au writes: Hi Rusty: I

Re: [PATCH] modules: add support for soft module dependencies

2013-09-10 Thread Herbert Xu
On Tue, Sep 10, 2013 at 11:01:38AM -0300, Lucas De Marchi wrote: However looking at the only user right now, crct10dif: couldn't we detect at runtime if this module can be used instead of just trying to load it as a pre softdep and possibly failing? No as sd_mod requires crct10dif to be

Re: [PATCH] modules: add support for soft module dependencies

2013-07-24 Thread Herbert Xu
On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell wrote: > Herbert Xu writes: > > Hi Rusty: > > > > I don't know why this patch never went into the kernel, even > > though the corresponding features have been added to modprobe > > in most if not all distros. > > Because Andreas never sent

[PATCH] modules: add support for soft module dependencies

2013-07-24 Thread Herbert Xu
Hi Rusty: I don't know why this patch never went into the kernel, even though the corresponding features have been added to modprobe in most if not all distros. This is required for dependencies on crypto modules such as crc32c where the dependency is only visible at run-time, which means that

Re: [PATCH] modules: add support for soft module dependencies

2013-07-24 Thread Herbert Xu
On Thu, Jul 25, 2013 at 09:32:02AM +0930, Rusty Russell wrote: Herbert Xu herb...@gondor.apana.org.au writes: Hi Rusty: I don't know why this patch never went into the kernel, even though the corresponding features have been added to modprobe in most if not all distros. Because

[PATCH] modules: add support for soft module dependencies

2013-07-24 Thread Herbert Xu
Hi Rusty: I don't know why this patch never went into the kernel, even though the corresponding features have been added to modprobe in most if not all distros. This is required for dependencies on crypto modules such as crc32c where the dependency is only visible at run-time, which means that