Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 14 Dec 2020 21:21:17 +0100 you wrote: > 'irq_of_parse_and_map()' should be balanced by a corresponding > 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks. > > Add such a call in the error handling

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Chen-Yu Tsai
On Wed, Dec 16, 2020 at 4:16 AM Christophe JAILLET wrote: > > Le 15/12/2020 à 20:35, Dan Carpenter a écrit : > > On Tue, Dec 15, 2020 at 08:08:15PM +0100, Maxime Ripard wrote: > >> On Tue, Dec 15, 2020 at 07:18:48PM +0100, Christophe JAILLET wrote: > >>> Le 15/12/2020 à 12:37, Maxime Ripard a

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Christophe JAILLET
Le 15/12/2020 à 20:35, Dan Carpenter a écrit : On Tue, Dec 15, 2020 at 08:08:15PM +0100, Maxime Ripard wrote: On Tue, Dec 15, 2020 at 07:18:48PM +0100, Christophe JAILLET wrote: Le 15/12/2020 à 12:37, Maxime Ripard a écrit : On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote: On

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Dan Carpenter
On Tue, Dec 15, 2020 at 08:08:15PM +0100, Maxime Ripard wrote: > On Tue, Dec 15, 2020 at 07:18:48PM +0100, Christophe JAILLET wrote: > > Le 15/12/2020 à 12:37, Maxime Ripard a écrit : > > > On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote: > > > > On Tue, Dec 15, 2020 at 09:56:55AM

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Maxime Ripard
On Tue, Dec 15, 2020 at 07:18:48PM +0100, Christophe JAILLET wrote: > Le 15/12/2020 à 12:37, Maxime Ripard a écrit : > > On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote: > > > On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote: > > > > Hi, > > > > > > > > On Mon, Dec 14,

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Christophe JAILLET
Le 15/12/2020 à 12:37, Maxime Ripard a écrit : On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote: On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote: Hi, On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote: 'irq_of_parse_and_map()' should be balanced by

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Maxime Ripard
On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote: > On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote: > > Hi, > > > > On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote: > > > 'irq_of_parse_and_map()' should be balanced by a corresponding > > >

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Dan Carpenter
On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote: > Hi, > > On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote: > > 'irq_of_parse_and_map()' should be balanced by a corresponding > > 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks. > > Do you

Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-15 Thread Maxime Ripard
Hi, On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote: > 'irq_of_parse_and_map()' should be balanced by a corresponding > 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks. Do you have a source to back that? It's not clear at all from the documentation for

[PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

2020-12-14 Thread Christophe JAILLET
'irq_of_parse_and_map()' should be balanced by a corresponding 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks. Add such a call in the error handling path of the probe function and in the remove function. Fixes: 492205050d77 ("net: Add EMAC ethernet driver found on