Re: [PATCH] net: pch_gbe: Fix memory leaks

2019-08-20 Thread Wenwen Wang
On Thu, Aug 15, 2019 at 4:51 PM David Miller wrote: > > From: Wenwen Wang > Date: Thu, 15 Aug 2019 16:46:05 -0400 > > > On Thu, Aug 15, 2019 at 4:42 PM David Miller wrote: > >> > >> From: Wenwen Wang > >> Date: Thu, 15 Aug 2019 16:03:39 -0400 > >> > >> > On Thu, Aug 15, 2019 at 3:34 PM David

Re: [PATCH] net: pch_gbe: Fix memory leaks

2019-08-15 Thread David Miller
From: Wenwen Wang Date: Thu, 15 Aug 2019 16:46:05 -0400 > On Thu, Aug 15, 2019 at 4:42 PM David Miller wrote: >> >> From: Wenwen Wang >> Date: Thu, 15 Aug 2019 16:03:39 -0400 >> >> > On Thu, Aug 15, 2019 at 3:34 PM David Miller wrote: >> >> >> >> From: Wenwen Wang >> >> Date: Tue, 13 Aug

Re: [PATCH] net: pch_gbe: Fix memory leaks

2019-08-15 Thread Wenwen Wang
On Thu, Aug 15, 2019 at 4:42 PM David Miller wrote: > > From: Wenwen Wang > Date: Thu, 15 Aug 2019 16:03:39 -0400 > > > On Thu, Aug 15, 2019 at 3:34 PM David Miller wrote: > >> > >> From: Wenwen Wang > >> Date: Tue, 13 Aug 2019 20:33:45 -0500 > >> > >> > In pch_gbe_set_ringparam(), if

Re: [PATCH] net: pch_gbe: Fix memory leaks

2019-08-15 Thread David Miller
From: Wenwen Wang Date: Thu, 15 Aug 2019 16:03:39 -0400 > On Thu, Aug 15, 2019 at 3:34 PM David Miller wrote: >> >> From: Wenwen Wang >> Date: Tue, 13 Aug 2019 20:33:45 -0500 >> >> > In pch_gbe_set_ringparam(), if netif_running() returns false, 'tx_old' and >> > 'rx_old' are not deallocated,

Re: [PATCH] net: pch_gbe: Fix memory leaks

2019-08-15 Thread Wenwen Wang
On Thu, Aug 15, 2019 at 3:34 PM David Miller wrote: > > From: Wenwen Wang > Date: Tue, 13 Aug 2019 20:33:45 -0500 > > > In pch_gbe_set_ringparam(), if netif_running() returns false, 'tx_old' and > > 'rx_old' are not deallocated, leading to memory leaks. To fix this issue, > > move the free

Re: [PATCH] net: pch_gbe: Fix memory leaks

2019-08-15 Thread David Miller
From: Wenwen Wang Date: Tue, 13 Aug 2019 20:33:45 -0500 > In pch_gbe_set_ringparam(), if netif_running() returns false, 'tx_old' and > 'rx_old' are not deallocated, leading to memory leaks. To fix this issue, > move the free statements after the if branch. > > Signed-off-by: Wenwen Wang Why

[PATCH] net: pch_gbe: Fix memory leaks

2019-08-13 Thread Wenwen Wang
In pch_gbe_set_ringparam(), if netif_running() returns false, 'tx_old' and 'rx_old' are not deallocated, leading to memory leaks. To fix this issue, move the free statements after the if branch. Signed-off-by: Wenwen Wang --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c | 4 ++-- 1