Re: [PATCH] nfp: Fix passing zero to 'PTR_ERR'

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 16:26:03 +0100 Simon Horman wrote: > On Thu, Nov 12, 2020 at 10:58:52PM +0800, YueHaibing wrote: > > nfp_cpp_from_nfp6000_pcie() returns ERR_PTR() and never returns > > NULL. The NULL test should be removed, also return correct err. > > > > Fixes: 63461a028f76 ("nfp: add the

Re: [PATCH] nfp: Fix passing zero to 'PTR_ERR'

2020-11-12 Thread Simon Horman
On Thu, Nov 12, 2020 at 10:58:52PM +0800, YueHaibing wrote: > nfp_cpp_from_nfp6000_pcie() returns ERR_PTR() and never returns > NULL. The NULL test should be removed, also return correct err. > > Fixes: 63461a028f76 ("nfp: add the PF driver") > Signed-off-by: YueHaibing Thanks, this does indeed

[PATCH] nfp: Fix passing zero to 'PTR_ERR'

2020-11-12 Thread YueHaibing
nfp_cpp_from_nfp6000_pcie() returns ERR_PTR() and never returns NULL. The NULL test should be removed, also return correct err. Fixes: 63461a028f76 ("nfp: add the PF driver") Signed-off-by: YueHaibing --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 4 +--- 1 file changed, 1 insertion(+), 3