RE: [PATCH] nfp: remove h from printk format specifier

2020-12-26 Thread David Laight
From: Tom Rix > Sent: 25 December 2020 14:57 ... > > Kernel code doesn't use a signed char or short with %hx or %hu very often > > but in case you didn't already know, any signed char/short emitted with > > anything like %hx or %hu needs to be left alone as sign extension occurs so: > > Yes, this

Re: [PATCH] nfp: remove h from printk format specifier

2020-12-25 Thread Joe Perches
On Fri, 2020-12-25 at 14:13 -0800, Tom Rix wrote: > On 12/25/20 9:06 AM, Joe Perches wrote: > > On Fri, 2020-12-25 at 06:56 -0800, Tom Rix wrote: > > > On 12/24/20 2:39 PM, Joe Perches wrote: > > [] > > > > Kernel code doesn't use a signed char or short with %hx or %hu very > > > > often > > > >

Re: [PATCH] nfp: remove h from printk format specifier

2020-12-25 Thread Tom Rix
On 12/25/20 9:06 AM, Joe Perches wrote: > On Fri, 2020-12-25 at 06:56 -0800, Tom Rix wrote: >> On 12/24/20 2:39 PM, Joe Perches wrote: > [] >>> Kernel code doesn't use a signed char or short with %hx or %hu very often >>> but in case you didn't already know, any signed char/short emitted with

Re: [PATCH] nfp: remove h from printk format specifier

2020-12-25 Thread Joe Perches
On Fri, 2020-12-25 at 06:56 -0800, Tom Rix wrote: > On 12/24/20 2:39 PM, Joe Perches wrote: [] > > Kernel code doesn't use a signed char or short with %hx or %hu very often > > but in case you didn't already know, any signed char/short emitted with > > anything like %hx or %hu needs to be left

Re: [PATCH] nfp: remove h from printk format specifier

2020-12-25 Thread Tom Rix
On 12/24/20 2:39 PM, Joe Perches wrote: > On Thu, 2020-12-24 at 14:14 -0800, Tom Rix wrote: >> On 12/24/20 12:21 PM, Simon Horman wrote: >>> On Wed, Dec 23, 2020 at 12:20:53PM -0800, t...@redhat.com wrote: From: Tom Rix This change fixes the checkpatch warning described in this

Re: [PATCH] nfp: remove h from printk format specifier

2020-12-24 Thread Joe Perches
On Thu, 2020-12-24 at 14:14 -0800, Tom Rix wrote: > On 12/24/20 12:21 PM, Simon Horman wrote: > > On Wed, Dec 23, 2020 at 12:20:53PM -0800, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > This change fixes the checkpatch warning described in this commit > > > commit cbacb5ab0aa0 ("docs:

Re: [PATCH] nfp: remove h from printk format specifier

2020-12-24 Thread Tom Rix
On 12/24/20 12:21 PM, Simon Horman wrote: > On Wed, Dec 23, 2020 at 12:20:53PM -0800, t...@redhat.com wrote: >> From: Tom Rix >> >> This change fixes the checkpatch warning described in this commit >> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of >> unnecessary %h[xudi]

Re: [PATCH] nfp: remove h from printk format specifier

2020-12-24 Thread Simon Horman
On Wed, Dec 23, 2020 at 12:20:53PM -0800, t...@redhat.com wrote: > From: Tom Rix > > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is

[PATCH] nfp: remove h from printk format specifier

2020-12-23 Thread trix
From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of