Re: [PATCH] posix-cpu-timers: Merge running and checking_timer state in one field

2015-10-20 Thread Jason Low
On Tue, 2015-10-20 at 02:18 +0200, Frederic Weisbecker wrote: > This way we might consume less space in the signal struct (well, > depending on bool size or padding) and we don't need to worry about > ordering between the running and checking_timers fields. This looks fine to me. I ended up going

Re: [PATCH] posix-cpu-timers: Merge running and checking_timer state in one field

2015-10-20 Thread Jason Low
On Tue, 2015-10-20 at 02:18 +0200, Frederic Weisbecker wrote: > This way we might consume less space in the signal struct (well, > depending on bool size or padding) and we don't need to worry about > ordering between the running and checking_timers fields. This looks fine to me. I ended up going

Re: [PATCH] posix-cpu-timers: Merge running and checking_timer state in one field

2015-10-19 Thread Frederic Weisbecker
On Mon, Oct 19, 2015 at 05:41:08PM -0700, Davidlohr Bueso wrote: > On Tue, 20 Oct 2015, Frederic Weisbecker wrote: > > >- * @checking_timer: true when a thread in the group is in the > >- * process of checking for thread group timers. > >- * > >+ * @state: flags

Re: [PATCH] posix-cpu-timers: Merge running and checking_timer state in one field

2015-10-19 Thread Davidlohr Bueso
On Tue, 20 Oct 2015, Frederic Weisbecker wrote: - * @checking_timer:true when a thread in the group is in the - * process of checking for thread group timers. - * + * @state: flags describing the current state of the cputimer. + *

[PATCH] posix-cpu-timers: Merge running and checking_timer state in one field

2015-10-19 Thread Frederic Weisbecker
This way we might consume less space in the signal struct (well, depending on bool size or padding) and we don't need to worry about ordering between the running and checking_timers fields. Cc: Jason Low Cc: Oleg Nesterov Cc: George Spelvin Cc: Paul E. McKenney Cc: Davidlohr Bueso Cc: Peter

[PATCH] posix-cpu-timers: Merge running and checking_timer state in one field

2015-10-19 Thread Frederic Weisbecker
This way we might consume less space in the signal struct (well, depending on bool size or padding) and we don't need to worry about ordering between the running and checking_timers fields. Cc: Jason Low Cc: Oleg Nesterov Cc: George Spelvin

Re: [PATCH] posix-cpu-timers: Merge running and checking_timer state in one field

2015-10-19 Thread Davidlohr Bueso
On Tue, 20 Oct 2015, Frederic Weisbecker wrote: - * @checking_timer:true when a thread in the group is in the - * process of checking for thread group timers. - * + * @state: flags describing the current state of the cputimer. + *

Re: [PATCH] posix-cpu-timers: Merge running and checking_timer state in one field

2015-10-19 Thread Frederic Weisbecker
On Mon, Oct 19, 2015 at 05:41:08PM -0700, Davidlohr Bueso wrote: > On Tue, 20 Oct 2015, Frederic Weisbecker wrote: > > >- * @checking_timer: true when a thread in the group is in the > >- * process of checking for thread group timers. > >- * > >+ * @state: flags