Re: [PATCH] sched/core: fix formatting issues in sched_can_stop_tick()

2014-04-14 Thread Viresh Kumar
On 15 April 2014 04:18, Frederic Weisbecker wrote: > Right, I have a pending patch for that: > https://git.kernel.org/cgit/linux/kernel/git/frederic/linux-dynticks.git/commit/?h=nohz/ipi=ca981d9f87fe0f113ad972098cfe181180b3675a Cool!! I will rebase my patch over yours and resend. -- To

Re: [PATCH] sched/core: fix formatting issues in sched_can_stop_tick()

2014-04-14 Thread Frederic Weisbecker
On Mon, Apr 14, 2014 at 08:38:38PM +0200, Peter Zijlstra wrote: > On Mon, Apr 14, 2014 at 09:47:41PM +0530, Viresh Kumar wrote: > > sched_can_stop_tick() was using 7 spaces instead of 8 spaces or a 'tab' at > > the > > beginning of each line. Which doesn't align with the Coding Guidelines. > > >

Re: [PATCH] sched/core: fix formatting issues in sched_can_stop_tick()

2014-04-14 Thread Peter Zijlstra
On Mon, Apr 14, 2014 at 09:47:41PM +0530, Viresh Kumar wrote: > sched_can_stop_tick() was using 7 spaces instead of 8 spaces or a 'tab' at the > beginning of each line. Which doesn't align with the Coding Guidelines. > > Also it removes the *rq variable as it was used at only one place and hence

[PATCH] sched/core: fix formatting issues in sched_can_stop_tick()

2014-04-14 Thread Viresh Kumar
sched_can_stop_tick() was using 7 spaces instead of 8 spaces or a 'tab' at the beginning of each line. Which doesn't align with the Coding Guidelines. Also it removes the *rq variable as it was used at only one place and hence we can directly use this_rq() instead. Signed-off-by: Viresh Kumar

Re: [PATCH] sched/core: fix formatting issues in sched_can_stop_tick()

2014-04-14 Thread Frederic Weisbecker
On Mon, Apr 14, 2014 at 08:38:38PM +0200, Peter Zijlstra wrote: On Mon, Apr 14, 2014 at 09:47:41PM +0530, Viresh Kumar wrote: sched_can_stop_tick() was using 7 spaces instead of 8 spaces or a 'tab' at the beginning of each line. Which doesn't align with the Coding Guidelines. Also it

Re: [PATCH] sched/core: fix formatting issues in sched_can_stop_tick()

2014-04-14 Thread Viresh Kumar
On 15 April 2014 04:18, Frederic Weisbecker fweis...@gmail.com wrote: Right, I have a pending patch for that: https://git.kernel.org/cgit/linux/kernel/git/frederic/linux-dynticks.git/commit/?h=nohz/ipiid=ca981d9f87fe0f113ad972098cfe181180b3675a Cool!! I will rebase my patch over yours and

[PATCH] sched/core: fix formatting issues in sched_can_stop_tick()

2014-04-14 Thread Viresh Kumar
sched_can_stop_tick() was using 7 spaces instead of 8 spaces or a 'tab' at the beginning of each line. Which doesn't align with the Coding Guidelines. Also it removes the *rq variable as it was used at only one place and hence we can directly use this_rq() instead. Signed-off-by: Viresh Kumar

Re: [PATCH] sched/core: fix formatting issues in sched_can_stop_tick()

2014-04-14 Thread Peter Zijlstra
On Mon, Apr 14, 2014 at 09:47:41PM +0530, Viresh Kumar wrote: sched_can_stop_tick() was using 7 spaces instead of 8 spaces or a 'tab' at the beginning of each line. Which doesn't align with the Coding Guidelines. Also it removes the *rq variable as it was used at only one place and hence we