Re: [PATCH] scsi: 3w-{sas,9xxx}: Use unsigned char for cdb

2018-10-23 Thread Martin K. Petersen
Nathan, > Clang warns a few times: > > drivers/scsi/3w-sas.c:386:11: warning: implicit conversion from 'int' to > 'char' changes value from 128 to -128 [-Wconstant-conversion] > cdb[4] = TW_ALLOCATION_LENGTH; /* allocation length */ >~ ^~~~ > > Update

Re: [PATCH] scsi: 3w-{sas,9xxx}: Use unsigned char for cdb

2018-10-23 Thread Martin K. Petersen
Nathan, > Clang warns a few times: > > drivers/scsi/3w-sas.c:386:11: warning: implicit conversion from 'int' to > 'char' changes value from 128 to -128 [-Wconstant-conversion] > cdb[4] = TW_ALLOCATION_LENGTH; /* allocation length */ >~ ^~~~ > > Update