Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-08-17 Thread Andres Salomon
Looks good to me, thanks. Acked-by: Andres Salomon On Fri, 17 Aug 2012 14:37:21 +0900 Toshiaki Yamane wrote: > The below checkpatch warnings was fixed, > > - WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ... > - WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ... > - WARNING:

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-08-17 Thread Andres Salomon
Looks good to me, thanks. Acked-by: Andres Salomon dilin...@queued.net On Fri, 17 Aug 2012 14:37:21 +0900 Toshiaki Yamane yamaneto...@gmail.com wrote: The below checkpatch warnings was fixed, - WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ... - WARNING: Prefer pr_warn(... to

[PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-08-16 Thread Toshiaki Yamane
The below checkpatch warnings was fixed, - WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ... - WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ... - WARNING: Prefer pr_info(... to printk(KERN_INFO, ... - WARNING: Prefer pr_err(... to printk(KERN_ERR, ... And added pr_fmt.

[PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-08-16 Thread Toshiaki Yamane
The below checkpatch warnings was fixed, - WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ... - WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ... - WARNING: Prefer pr_info(... to printk(KERN_INFO, ... - WARNING: Prefer pr_err(... to printk(KERN_ERR, ... And added pr_fmt.

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-08-13 Thread Greg Kroah-Hartman
On Fri, Jul 27, 2012 at 08:45:52PM +0900, Toshiaki Yamane wrote: > fixed some checkpatch warnings. > (Excluding -WARNING: msleep < 20ms can sleep for up to 20ms-) Then fix your changelog entry: > > $ find drivers/staging/olpc_dcon/ -name "*.[ch]"|xargs > ./scripts/checkpatch.pl \ > -f --terse

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-08-13 Thread Greg Kroah-Hartman
On Fri, Jul 27, 2012 at 08:45:52PM +0900, Toshiaki Yamane wrote: fixed some checkpatch warnings. (Excluding -WARNING: msleep 20ms can sleep for up to 20ms-) Then fix your changelog entry: $ find drivers/staging/olpc_dcon/ -name *.[ch]|xargs ./scripts/checkpatch.pl \ -f --terse

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-27 Thread Andres Salomon
Looks fine to me, thanks. Acked-by: Andres Salomon On Fri, 27 Jul 2012 20:45:52 +0900 Toshiaki Yamane wrote: > fixed some checkpatch warnings. > (Excluding -WARNING: msleep < 20ms can sleep for up to 20ms-) > > $ find drivers/staging/olpc_dcon/ -name > "*.[ch]"|xargs ./scripts/checkpatch.pl

[PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-27 Thread Toshiaki Yamane
fixed some checkpatch warnings. (Excluding -WARNING: msleep < 20ms can sleep for up to 20ms-) $ find drivers/staging/olpc_dcon/ -name "*.[ch]"|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut -f3- -d":"|sort |uniq -c|sort -n 2 WARNING: msleep < 20ms can sleep for up to 20ms; see

[PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-27 Thread Toshiaki Yamane
fixed some checkpatch warnings. (Excluding -WARNING: msleep 20ms can sleep for up to 20ms-) $ find drivers/staging/olpc_dcon/ -name *.[ch]|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut -f3- -d:|sort |uniq -c|sort -n 2 WARNING: msleep 20ms can sleep for up to 20ms; see

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-27 Thread Andres Salomon
Looks fine to me, thanks. Acked-by: Andres Salomon dilin...@queued.net On Fri, 27 Jul 2012 20:45:52 +0900 Toshiaki Yamane yamaneto...@gmail.com wrote: fixed some checkpatch warnings. (Excluding -WARNING: msleep 20ms can sleep for up to 20ms-) $ find drivers/staging/olpc_dcon/ -name

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Toshiaki Yamane
On Fri, Jul 27, 2012 at 2:03 PM, Joe Perches wrote: > On Fri, 2012-07-27 at 13:46 +0900, Toshiaki Yamane wrote: >> fixed some checkpatch warnings. >> (Excluding -WARNING: msleep < 20ms can sleep for up to 20ms-) > [] >> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c >>

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Joe Perches
On Fri, 2012-07-27 at 13:46 +0900, Toshiaki Yamane wrote: > fixed some checkpatch warnings. > (Excluding -WARNING: msleep < 20ms can sleep for up to 20ms-) [] > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c > b/drivers/staging/olpc_dcon/olpc_dcon.c [] > @@ -71,18 +72,18 @@ static int

[PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Toshiaki Yamane
fixed some checkpatch warnings. (Excluding -WARNING: msleep < 20ms can sleep for up to 20ms-) $ find drivers/staging/olpc_dcon/ -name "*.[ch]"|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut -f3- -d":"|sort |uniq -c|sort -n 2 WARNING: msleep < 20ms can sleep for up to 20ms; see

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Toshiaki Yamane
On Fri, Jul 27, 2012 at 11:28 AM, Andres Salomon wrote: > On Fri, 27 Jul 2012 08:49:19 +0900 > Toshiaki Yamane wrote: > >> Now checkpatch clean. >> >> $ find drivers/staging/olpc_dcon/ -name >> "*.[ch]"|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut >> -f3- -d":"|sort |uniq -c|sort

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Andres Salomon
On Fri, 27 Jul 2012 08:49:19 +0900 Toshiaki Yamane wrote: > Now checkpatch clean. > > $ find drivers/staging/olpc_dcon/ -name > "*.[ch]"|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut > -f3- -d":"|sort |uniq -c|sort -n 2 WARNING: msleep < 20ms can sleep > for up to 20ms; see

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Toshiaki Yamane
On Fri, Jul 27, 2012 at 10:40 AM, Joe Perches wrote: > On Fri, 2012-07-27 at 08:49 +0900, Toshiaki Yamane wrote: >> Now checkpatch clean. > [] >> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c >> b/drivers/staging/olpc_dcon/olpc_dcon.c > [] >> @@ -11,6 +11,7 @@ > [] >> +#define pr_fmt(fmt)

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Joe Perches
On Fri, 2012-07-27 at 08:49 +0900, Toshiaki Yamane wrote: > Now checkpatch clean. [] > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c > b/drivers/staging/olpc_dcon/olpc_dcon.c [] > @@ -11,6 +11,7 @@ [] > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt [] > @@ -71,18 +72,18 @@ static int

[PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Toshiaki Yamane
Now checkpatch clean. $ find drivers/staging/olpc_dcon/ -name "*.[ch]"|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut -f3- -d":"|sort |uniq -c|sort -n 2 WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt 3 WARNING: Prefer

[PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Toshiaki Yamane
Now checkpatch clean. $ find drivers/staging/olpc_dcon/ -name *.[ch]|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut -f3- -d:|sort |uniq -c|sort -n 2 WARNING: msleep 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt 3 WARNING: Prefer pr_debug(...

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Joe Perches
On Fri, 2012-07-27 at 08:49 +0900, Toshiaki Yamane wrote: Now checkpatch clean. [] diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c [] @@ -11,6 +11,7 @@ [] +#define pr_fmt(fmt) KBUILD_MODNAME : fmt [] @@ -71,18 +72,18 @@ static int

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Toshiaki Yamane
On Fri, Jul 27, 2012 at 10:40 AM, Joe Perches j...@perches.com wrote: On Fri, 2012-07-27 at 08:49 +0900, Toshiaki Yamane wrote: Now checkpatch clean. [] diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c [] @@ -11,6 +11,7 @@ [] +#define pr_fmt(fmt)

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Andres Salomon
On Fri, 27 Jul 2012 08:49:19 +0900 Toshiaki Yamane yamaneto...@gmail.com wrote: Now checkpatch clean. $ find drivers/staging/olpc_dcon/ -name *.[ch]|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut -f3- -d:|sort |uniq -c|sort -n 2 WARNING: msleep 20ms can sleep for up to 20ms;

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Toshiaki Yamane
On Fri, Jul 27, 2012 at 11:28 AM, Andres Salomon dilin...@queued.net wrote: On Fri, 27 Jul 2012 08:49:19 +0900 Toshiaki Yamane yamaneto...@gmail.com wrote: Now checkpatch clean. $ find drivers/staging/olpc_dcon/ -name *.[ch]|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut -f3-

[PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Toshiaki Yamane
fixed some checkpatch warnings. (Excluding -WARNING: msleep 20ms can sleep for up to 20ms-) $ find drivers/staging/olpc_dcon/ -name *.[ch]|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut -f3- -d:|sort |uniq -c|sort -n 2 WARNING: msleep 20ms can sleep for up to 20ms; see

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Joe Perches
On Fri, 2012-07-27 at 13:46 +0900, Toshiaki Yamane wrote: fixed some checkpatch warnings. (Excluding -WARNING: msleep 20ms can sleep for up to 20ms-) [] diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c [] @@ -71,18 +72,18 @@ static int

Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

2012-07-26 Thread Toshiaki Yamane
On Fri, Jul 27, 2012 at 2:03 PM, Joe Perches j...@perches.com wrote: On Fri, 2012-07-27 at 13:46 +0900, Toshiaki Yamane wrote: fixed some checkpatch warnings. (Excluding -WARNING: msleep 20ms can sleep for up to 20ms-) [] diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c