Re: [PATCH] thermal: rcar_gen3_thermal: Fix Wshift-negative-value

2019-08-31 Thread Simon Horman
On Thu, Aug 29, 2019 at 03:11:24PM +0200, Wolfram Sang wrote: > On Wed, Aug 28, 2019 at 04:52:20PM +0800, Zhang Rui wrote: > > On Fri, 2019-06-14 at 12:52 +0200, Daniel Lezcano wrote: > > > Hi Nathan, > > > > > > On 13/06/2019 23:12, Nathan Huckleberry wrote: > > > > Clang produces the following

Re: [PATCH] thermal: rcar_gen3_thermal: Fix Wshift-negative-value

2019-08-29 Thread Wolfram Sang
On Wed, Aug 28, 2019 at 04:52:20PM +0800, Zhang Rui wrote: > On Fri, 2019-06-14 at 12:52 +0200, Daniel Lezcano wrote: > > Hi Nathan, > > > > On 13/06/2019 23:12, Nathan Huckleberry wrote: > > > Clang produces the following warning > > > > > > vers/thermal/rcar_gen3_thermal.c:147:33: warning:

Re: [PATCH] thermal: rcar_gen3_thermal: Fix Wshift-negative-value

2019-08-28 Thread Zhang Rui
On Fri, 2019-06-14 at 12:52 +0200, Daniel Lezcano wrote: > Hi Nathan, > > On 13/06/2019 23:12, Nathan Huckleberry wrote: > > Clang produces the following warning > > > > vers/thermal/rcar_gen3_thermal.c:147:33: warning: shifting a > > negative > > signed value is undefined

Re: [PATCH] thermal: rcar_gen3_thermal: Fix Wshift-negative-value

2019-08-13 Thread Nathan Huckleberry
I'm not familiar enough with the code to rewrite these parts of the driver. Silencing the warnings while maintaining the same functionality was the goal of this patch. On Fri, Jun 14, 2019 at 3:52 AM Daniel Lezcano wrote: > > > Hi Nathan, > > On 13/06/2019 23:12, Nathan Huckleberry wrote: > >

Re: [PATCH] thermal: rcar_gen3_thermal: Fix Wshift-negative-value

2019-06-14 Thread Daniel Lezcano
Hi Nathan, On 13/06/2019 23:12, Nathan Huckleberry wrote: > Clang produces the following warning > > vers/thermal/rcar_gen3_thermal.c:147:33: warning: shifting a negative > signed value is undefined [-Wshift-negative-value] / (ptat[0] - ptat[2])) + > FIXPT_INT(TJ_3); ^~~

[PATCH] thermal: rcar_gen3_thermal: Fix Wshift-negative-value

2019-06-13 Thread Nathan Huckleberry
Clang produces the following warning vers/thermal/rcar_gen3_thermal.c:147:33: warning: shifting a negative signed value is undefined [-Wshift-negative-value] / (ptat[0] - ptat[2])) + FIXPT_INT(TJ_3); ^~~ drivers/thermal/rcar_gen3_thermal.c:126:29 note: expanded from macro 'FIXPT_INT'