Re: [PATCH] um: Rewrite host RNG driver.

2019-08-29 Thread Johannes Berg
On Thu, 2019-08-29 at 13:10 -0400, Dark wrote: > (I'm unsure of how to submit an update > to my patch so I'll need a bit of guidence on this.) Resend the patch, but use --subject-prefix 'PATCH v2' and ideally note somewhere in the patch (possibly after a "---" marker after Signed-off- by) the

Re: [PATCH] um: Rewrite host RNG driver.

2019-08-29 Thread Dark
rger" , "linux-kernel" > > > > CC: "richard" , "anton ivanov" > > , "linux-um" > > > > Gesendet: Donnerstag, 29. August 2019 16:36:28 > > Betreff: Re: [PATCH] um: Rewrite host RNG driver. > > > On Thu, 29 Aug 201

Re: [PATCH] um: Rewrite host RNG driver.

2019-08-29 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Dark" > An: "Richard Weinberger" , "linux-kernel" > > CC: "richard" , "anton ivanov" > , "linux-um" > > Gesendet: Donnerstag, 29. August 2019 16:36:28 > Betreff: Re:

Re: [PATCH] um: Rewrite host RNG driver.

2019-08-29 Thread Dark
On Thu, 29 Aug 2019 15:26:24 +0200, Richard Weinberger wrote: > So, you removed -EAGAIN handling, made everything synchronous, > and changed the interface.t > I'm not sure if this really a much better option. I should have been more clear here that I'm using the interfaces provided by

Re: [PATCH] um: Rewrite host RNG driver.

2019-08-29 Thread Johannes Berg
On Wed, 2019-08-28 at 21:44 -0400, Alexander Neville wrote: > The old driver had a bug that would cause it to outright stop working if > the host's /dev/random were to block. Instead of trying to track down > the cause of said bug, rewriting it from scratch turned out to be a much > better option

Re: [PATCH] um: Rewrite host RNG driver.

2019-08-29 Thread Richard Weinberger
On Thu, Aug 29, 2019 at 3:45 AM Alexander Neville wrote: > > The old driver had a bug that would cause it to outright stop working if > the host's /dev/random were to block. Instead of trying to track down > the cause of said bug, rewriting it from scratch turned out to be a much > better option

[PATCH] um: Rewrite host RNG driver.

2019-08-28 Thread Alexander Neville
The old driver had a bug that would cause it to outright stop working if the host's /dev/random were to block. Instead of trying to track down the cause of said bug, rewriting it from scratch turned out to be a much better option as it came with a few benefits: - The new driver properly