Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-08 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-08 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-06 Thread Darrick J. Wong
On Tue, Mar 06, 2018 at 11:26:38AM +0100, Vratislav Bendel wrote: > Due to an inverted logic mistake in xfs_buftarg_isolate() > the xfs_buffers with zero b_lru_ref will take another trip > around LRU, while isolating buffers with non-zero b_lru_ref. > > Additionally those isolated buffers end up

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-06 Thread Darrick J. Wong
On Tue, Mar 06, 2018 at 11:26:38AM +0100, Vratislav Bendel wrote: > Due to an inverted logic mistake in xfs_buftarg_isolate() > the xfs_buffers with zero b_lru_ref will take another trip > around LRU, while isolating buffers with non-zero b_lru_ref. > > Additionally those isolated buffers end up

[PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-06 Thread Vratislav Bendel
Due to an inverted logic mistake in xfs_buftarg_isolate() the xfs_buffers with zero b_lru_ref will take another trip around LRU, while isolating buffers with non-zero b_lru_ref. Additionally those isolated buffers end up right back on the LRU once they are released, because b_lru_ref remains

[PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-06 Thread Vratislav Bendel
Due to an inverted logic mistake in xfs_buftarg_isolate() the xfs_buffers with zero b_lru_ref will take another trip around LRU, while isolating buffers with non-zero b_lru_ref. Additionally those isolated buffers end up right back on the LRU once they are released, because b_lru_ref remains

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-05 Thread Darrick J. Wong
On Mon, Mar 05, 2018 at 11:19:46AM +0100, Vratislav Bendel wrote: > (In response to Luis' comment:) > > Can you add a respective Fixes: tag? > > It was apparently present since LRU was added to xfs buffer cache via: > commit 430cbeb86fdcbbdabea7d4aa65307de8de425350 > [xfs: add a lru to the XFS

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-05 Thread Darrick J. Wong
On Mon, Mar 05, 2018 at 11:19:46AM +0100, Vratislav Bendel wrote: > (In response to Luis' comment:) > > Can you add a respective Fixes: tag? > > It was apparently present since LRU was added to xfs buffer cache via: > commit 430cbeb86fdcbbdabea7d4aa65307de8de425350 > [xfs: add a lru to the XFS

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-05 Thread Vratislav Bendel
(In response to Luis' comment:) > Can you add a respective Fixes: tag? It was apparently present since LRU was added to xfs buffer cache via: commit 430cbeb86fdcbbdabea7d4aa65307de8de425350 [xfs: add a lru to the XFS buffer cache] But I wouldn't say this patch "fixes" that commit. What do you

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-05 Thread Vratislav Bendel
(In response to Luis' comment:) > Can you add a respective Fixes: tag? It was apparently present since LRU was added to xfs buffer cache via: commit 430cbeb86fdcbbdabea7d4aa65307de8de425350 [xfs: add a lru to the XFS buffer cache] But I wouldn't say this patch "fixes" that commit. What do you

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-02 Thread Darrick J. Wong
On Thu, Mar 01, 2018 at 02:48:00PM -0800, Darrick J. Wong wrote: > On Wed, Feb 28, 2018 at 04:49:51PM +0100, Vratislav Bendel wrote: > > The function xfs_buftarg_isolate() used by xfs buffer schrinkers > > to determine whether a buffer should be isolated and disposed > > from LRU list, has

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-02 Thread Darrick J. Wong
On Thu, Mar 01, 2018 at 02:48:00PM -0800, Darrick J. Wong wrote: > On Wed, Feb 28, 2018 at 04:49:51PM +0100, Vratislav Bendel wrote: > > The function xfs_buftarg_isolate() used by xfs buffer schrinkers > > to determine whether a buffer should be isolated and disposed > > from LRU list, has

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-01 Thread Darrick J. Wong
On Wed, Feb 28, 2018 at 04:49:51PM +0100, Vratislav Bendel wrote: > The function xfs_buftarg_isolate() used by xfs buffer schrinkers > to determine whether a buffer should be isolated and disposed > from LRU list, has inverted logic. > > Excerpt from xfs_buftarg_isolate(): > /* >

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-01 Thread Darrick J. Wong
On Wed, Feb 28, 2018 at 04:49:51PM +0100, Vratislav Bendel wrote: > The function xfs_buftarg_isolate() used by xfs buffer schrinkers > to determine whether a buffer should be isolated and disposed > from LRU list, has inverted logic. > > Excerpt from xfs_buftarg_isolate(): > /* >

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-01 Thread Brian Foster
On Wed, Feb 28, 2018 at 04:49:51PM +0100, Vratislav Bendel wrote: > The function xfs_buftarg_isolate() used by xfs buffer schrinkers > to determine whether a buffer should be isolated and disposed > from LRU list, has inverted logic. > > Excerpt from xfs_buftarg_isolate(): > /* >

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-01 Thread Brian Foster
On Wed, Feb 28, 2018 at 04:49:51PM +0100, Vratislav Bendel wrote: > The function xfs_buftarg_isolate() used by xfs buffer schrinkers > to determine whether a buffer should be isolated and disposed > from LRU list, has inverted logic. > > Excerpt from xfs_buftarg_isolate(): > /* >

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-02-28 Thread Luis R. Rodriguez
On Wed, Feb 28, 2018 at 04:49:51PM +0100, Vratislav Bendel wrote: > The function xfs_buftarg_isolate() used by xfs buffer schrinkers > to determine whether a buffer should be isolated and disposed > from LRU list, has inverted logic. > > Excerpt from xfs_buftarg_isolate(): > /* >

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-02-28 Thread Luis R. Rodriguez
On Wed, Feb 28, 2018 at 04:49:51PM +0100, Vratislav Bendel wrote: > The function xfs_buftarg_isolate() used by xfs buffer schrinkers > to determine whether a buffer should be isolated and disposed > from LRU list, has inverted logic. > > Excerpt from xfs_buftarg_isolate(): > /* >

[PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-02-28 Thread Vratislav Bendel
The function xfs_buftarg_isolate() used by xfs buffer schrinkers to determine whether a buffer should be isolated and disposed from LRU list, has inverted logic. Excerpt from xfs_buftarg_isolate(): /* * Decrement the b_lru_ref count unless the value is already * zero.

[PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-02-28 Thread Vratislav Bendel
The function xfs_buftarg_isolate() used by xfs buffer schrinkers to determine whether a buffer should be isolated and disposed from LRU list, has inverted logic. Excerpt from xfs_buftarg_isolate(): /* * Decrement the b_lru_ref count unless the value is already * zero.