Re: [PATCH -tip 03/32] sched/fair: Fix pick_task_fair crashes due to empty rbtree

2020-11-24 Thread Peter Zijlstra
On Fri, Nov 20, 2020 at 09:15:28PM +1100, Singh, Balbir wrote: > On 18/11/20 10:19 am, Joel Fernandes (Google) wrote: > > From: Peter Zijlstra > > > > pick_next_entity() is passed curr == NULL during core-scheduling. Due to > > this, if the rbtree is empty, the 'left' variable is set to NULL

Re: [PATCH -tip 03/32] sched/fair: Fix pick_task_fair crashes due to empty rbtree

2020-11-23 Thread Balbir Singh
On Fri, Nov 20, 2020 at 01:11:06PM -0500, Vineeth Pillai wrote: > Hi Balbir, > > On 11/20/20 5:15 AM, Singh, Balbir wrote: > > On 18/11/20 10:19 am, Joel Fernandes (Google) wrote: > > > From: Peter Zijlstra > > > > > > pick_next_entity() is passed curr == NULL during core-scheduling. Due to > >

Re: [PATCH -tip 03/32] sched/fair: Fix pick_task_fair crashes due to empty rbtree

2020-11-20 Thread Vineeth Pillai
Hi Balbir, On 11/20/20 5:15 AM, Singh, Balbir wrote: On 18/11/20 10:19 am, Joel Fernandes (Google) wrote: From: Peter Zijlstra pick_next_entity() is passed curr == NULL during core-scheduling. Due to this, if the rbtree is empty, the 'left' variable is set to NULL within the function. This

Re: [PATCH -tip 03/32] sched/fair: Fix pick_task_fair crashes due to empty rbtree

2020-11-20 Thread Singh, Balbir
On 18/11/20 10:19 am, Joel Fernandes (Google) wrote: > From: Peter Zijlstra > > pick_next_entity() is passed curr == NULL during core-scheduling. Due to > this, if the rbtree is empty, the 'left' variable is set to NULL within > the function. This can cause crashes within the function. > > This

[PATCH -tip 03/32] sched/fair: Fix pick_task_fair crashes due to empty rbtree

2020-11-17 Thread Joel Fernandes (Google)
From: Peter Zijlstra pick_next_entity() is passed curr == NULL during core-scheduling. Due to this, if the rbtree is empty, the 'left' variable is set to NULL within the function. This can cause crashes within the function. This is not an issue if put_prev_task() is invoked on the currently