Re: [PATCH 0/2] Fix BUG: Invalid wait context in hrtimer_interrupt()

2021-01-26 Thread Petr Mladek
On Wed 2021-01-27 00:58:33, Sergey Senozhatsky wrote: > On (21/01/26 14:59), Qais Yousef wrote: > > On 01/26/21 13:46, Sergey Senozhatsky wrote: > > > On (21/01/23 23:37), Qais Yousef wrote: > > [..] > > > I reported it here: > >

Re: [PATCH 0/2] Fix BUG: Invalid wait context in hrtimer_interrupt()

2021-01-26 Thread Sergey Senozhatsky
On (21/01/23 23:37), Qais Yousef wrote: > > I hit a pr_warn() inside hrtimer_interrupt() which lead to a BUG: Invalid wait > context splat. > > The problem wasn't reproducible but I think the cause is obvious, printk can't > be called from interrupt context. > > AFAICU printk_deferred() is safe

Re: [PATCH 0/2] Fix BUG: Invalid wait context in hrtimer_interrupt()

2021-01-26 Thread Qais Yousef
On 01/26/21 17:23, Peter Zijlstra wrote: > On Wed, Jan 27, 2021 at 12:58:33AM +0900, Sergey Senozhatsky wrote: > > On (21/01/26 14:59), Qais Yousef wrote: > > > > # [67628.388606] hrtimer: interrupt took 304720 ns > > > [67628.393546] > > > [67628.393550] = > > >

Re: [PATCH 0/2] Fix BUG: Invalid wait context in hrtimer_interrupt()

2021-01-26 Thread Peter Zijlstra
On Wed, Jan 27, 2021 at 12:58:33AM +0900, Sergey Senozhatsky wrote: > On (21/01/26 14:59), Qais Yousef wrote: > > # [67628.388606] hrtimer: interrupt took 304720 ns > > [67628.393546] > > [67628.393550] = > > [67628.393554] [ BUG: Invalid wait context ]

Re: [PATCH 0/2] Fix BUG: Invalid wait context in hrtimer_interrupt()

2021-01-26 Thread Peter Zijlstra
On Tue, Jan 26, 2021 at 04:28:42PM +0106, John Ogness wrote: > On 2021-01-26, Qais Yousef wrote: > > [67628.393550] = > > [67628.393554] [ BUG: Invalid wait context ] > > [67628.393557] 5.11.0-rc3-00019-g86be331946f7 #37 Not tainted > > [67628.393560]

Re: [PATCH 0/2] Fix BUG: Invalid wait context in hrtimer_interrupt()

2021-01-26 Thread Sergey Senozhatsky
On (21/01/26 14:59), Qais Yousef wrote: > On 01/26/21 13:46, Sergey Senozhatsky wrote: > > On (21/01/23 23:37), Qais Yousef wrote: [..] > I reported it here: > https://lore.kernel.org/lkml/20210114124512.mg3vexudfmoadef5@e107158-lin/ > > # [67628.388606] hrtimer: interrupt took 304720 ns

Re: [PATCH 0/2] Fix BUG: Invalid wait context in hrtimer_interrupt()

2021-01-26 Thread John Ogness
On 2021-01-26, Qais Yousef wrote: > [67628.393550] = > [67628.393554] [ BUG: Invalid wait context ] > [67628.393557] 5.11.0-rc3-00019-g86be331946f7 #37 Not tainted > [67628.393560] - > [67628.393563] sugov:0/192

Re: [PATCH 0/2] Fix BUG: Invalid wait context in hrtimer_interrupt()

2021-01-26 Thread Qais Yousef
On 01/26/21 13:46, Sergey Senozhatsky wrote: > On (21/01/23 23:37), Qais Yousef wrote: > > > > I hit a pr_warn() inside hrtimer_interrupt() which lead to a BUG: Invalid > > wait > > context splat. > > > > The problem wasn't reproducible but I think the cause is obvious, printk > > can't > > be

[PATCH 0/2] Fix BUG: Invalid wait context in hrtimer_interrupt()

2021-01-23 Thread Qais Yousef
I hit a pr_warn() inside hrtimer_interrupt() which lead to a BUG: Invalid wait context splat. The problem wasn't reproducible but I think the cause is obvious, printk can't be called from interrupt context. AFAICU printk_deferred() is safe from NMI, so I assumed it is safe to be called from