Re: [PATCH 03/16] media: i2c: rdacm20: Replace goto with a loop

2021-02-25 Thread Kieran Bingham
On 24/02/2021 20:27, Laurent Pinchart wrote: > Hi Jacopo, > > On Mon, Feb 22, 2021 at 04:06:43PM +0100, Jacopo Mondi wrote: >> On Mon, Feb 22, 2021 at 03:05:03AM +0200, Laurent Pinchart wrote: >>> Hi Jacopo, >>> >>> Reviewed-by: Laurent Pinchart >>> >>> On Wed, Feb 17, 2021 at 01:01:26PM +,

Re: [PATCH 03/16] media: i2c: rdacm20: Replace goto with a loop

2021-02-24 Thread Laurent Pinchart
Hi Jacopo, On Mon, Feb 22, 2021 at 04:06:43PM +0100, Jacopo Mondi wrote: > On Mon, Feb 22, 2021 at 03:05:03AM +0200, Laurent Pinchart wrote: > > Hi Jacopo, > > > > Reviewed-by: Laurent Pinchart > > > > On Wed, Feb 17, 2021 at 01:01:26PM +, Kieran Bingham wrote: > > > On 16/02/2021 17:41,

Re: [PATCH 03/16] media: i2c: rdacm20: Replace goto with a loop

2021-02-22 Thread Jacopo Mondi
Hi, On Mon, Feb 22, 2021 at 03:05:03AM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Reviewed-by: Laurent Pinchart > > On Wed, Feb 17, 2021 at 01:01:26PM +, Kieran Bingham wrote: > > On 16/02/2021 17:41, Jacopo Mondi wrote: > > > During the camera module initialization the image sensor PID

Re: [PATCH 03/16] media: i2c: rdacm20: Replace goto with a loop

2021-02-21 Thread Laurent Pinchart
Hi Jacopo, Reviewed-by: Laurent Pinchart On Wed, Feb 17, 2021 at 01:01:26PM +, Kieran Bingham wrote: > On 16/02/2021 17:41, Jacopo Mondi wrote: > > During the camera module initialization the image sensor PID is read to > > verify it can correctly be identified. The current implementation

Re: [PATCH 03/16] media: i2c: rdacm20: Replace goto with a loop

2021-02-17 Thread Kieran Bingham
Hi Jacopo, On 16/02/2021 17:41, Jacopo Mondi wrote: > During the camera module initialization the image sensor PID is read to > verify it can correctly be identified. The current implementation is > rather confused and uses a loop implemented with a label and a goto. > > Replace it with a more

[PATCH 03/16] media: i2c: rdacm20: Replace goto with a loop

2021-02-16 Thread Jacopo Mondi
During the camera module initialization the image sensor PID is read to verify it can correctly be identified. The current implementation is rather confused and uses a loop implemented with a label and a goto. Replace it with a more compact for() loop. No functional changes intended.