Re: [PATCH 08/10] mm: count writeback pages per BDI

2007-04-22 Thread Peter Zijlstra
On Sun, 2007-04-22 at 00:19 -0700, Andrew Morton wrote: > It could be that we never call test_clear_page_writeback() against > !bdi_cap_writeback_dirty() pages anwyay. I can't think why we would, but > the relationships there aren't very clear. Does "don't account for dirty > memory" imply

Re: [PATCH 08/10] mm: count writeback pages per BDI

2007-04-22 Thread Andrew Morton
On Sat, 21 Apr 2007 13:07:16 +0200 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > On Sat, 2007-04-21 at 02:55 -0700, Andrew Morton wrote: > > On Fri, 20 Apr 2007 17:52:02 +0200 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > > > Count per BDI writeback pages. > > > > > > Signed-off-by: Peter

Re: [PATCH 08/10] mm: count writeback pages per BDI

2007-04-22 Thread Andrew Morton
On Sat, 21 Apr 2007 13:07:16 +0200 Peter Zijlstra [EMAIL PROTECTED] wrote: On Sat, 2007-04-21 at 02:55 -0700, Andrew Morton wrote: On Fri, 20 Apr 2007 17:52:02 +0200 Peter Zijlstra [EMAIL PROTECTED] wrote: Count per BDI writeback pages. Signed-off-by: Peter Zijlstra [EMAIL

Re: [PATCH 08/10] mm: count writeback pages per BDI

2007-04-22 Thread Peter Zijlstra
On Sun, 2007-04-22 at 00:19 -0700, Andrew Morton wrote: It could be that we never call test_clear_page_writeback() against !bdi_cap_writeback_dirty() pages anwyay. I can't think why we would, but the relationships there aren't very clear. Does don't account for dirty memory imply doesn't

Re: [PATCH 08/10] mm: count writeback pages per BDI

2007-04-21 Thread Peter Zijlstra
On Sat, 2007-04-21 at 02:55 -0700, Andrew Morton wrote: > On Fri, 20 Apr 2007 17:52:02 +0200 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > Count per BDI writeback pages. > > > > Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> > > --- > > include/linux/backing-dev.h |1 + > >

Re: [PATCH 08/10] mm: count writeback pages per BDI

2007-04-21 Thread Andrew Morton
On Fri, 20 Apr 2007 17:52:02 +0200 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > Count per BDI writeback pages. > > Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> > --- > include/linux/backing-dev.h |1 + > mm/page-writeback.c | 12 ++-- > 2 files changed, 11

Re: [PATCH 08/10] mm: count writeback pages per BDI

2007-04-21 Thread Andrew Morton
On Fri, 20 Apr 2007 17:52:02 +0200 Peter Zijlstra [EMAIL PROTECTED] wrote: Count per BDI writeback pages. Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- include/linux/backing-dev.h |1 + mm/page-writeback.c | 12 ++-- 2 files changed, 11 insertions(+), 2

Re: [PATCH 08/10] mm: count writeback pages per BDI

2007-04-21 Thread Peter Zijlstra
On Sat, 2007-04-21 at 02:55 -0700, Andrew Morton wrote: On Fri, 20 Apr 2007 17:52:02 +0200 Peter Zijlstra [EMAIL PROTECTED] wrote: Count per BDI writeback pages. Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- include/linux/backing-dev.h |1 + mm/page-writeback.c |

[PATCH 08/10] mm: count writeback pages per BDI

2007-04-20 Thread Peter Zijlstra
Count per BDI writeback pages. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/linux/backing-dev.h |1 + mm/page-writeback.c | 12 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) Index: linux-2.6/mm/page-writeback.c

[PATCH 08/10] mm: count writeback pages per BDI

2007-04-20 Thread Peter Zijlstra
Count per BDI writeback pages. Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- include/linux/backing-dev.h |1 + mm/page-writeback.c | 12 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) Index: linux-2.6/mm/page-writeback.c