Re: [PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console"

2021-01-08 Thread Linus Torvalds
On Fri, Jan 8, 2021 at 9:45 AM Petr Mladek wrote: > > Feel free to push v2 directly. Thanks, done. Linus

Re: [PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console"

2021-01-08 Thread Vineet Gupta
On 1/8/21 9:45 AM, Petr Mladek wrote: > On Thu 2021-01-07 11:38:36, Linus Torvalds wrote: >> On Thu, Jan 7, 2021 at 11:15 AM Greg Kroah-Hartman >> wrote: >>> Linus, can you take this directly, or is this going through some other >>> tree? >> I was _assuming_ that I'd get it through the normal

Re: [PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console"

2021-01-08 Thread Petr Mladek
On Thu 2021-01-07 11:38:36, Linus Torvalds wrote: > On Thu, Jan 7, 2021 at 11:15 AM Greg Kroah-Hartman > wrote: > > > > Linus, can you take this directly, or is this going through some other > > tree? > > I was _assuming_ that I'd get it through the normal printk pull > request, it doesn't seem

Re: [PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console"

2021-01-07 Thread Sergey Senozhatsky
On (21/01/07 17:44), Petr Mladek wrote: > > This reverts commit 757055ae8dedf5333af17b3b5b4b70ba9bc9da4e. > > The commit caused that ttynull was used as the default console > on many systems. It happened when there was no console configured > on the command line and ttynull_init() was the first

Re: [PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console"

2021-01-07 Thread Linus Torvalds
On Thu, Jan 7, 2021 at 11:15 AM Greg Kroah-Hartman wrote: > > Linus, can you take this directly, or is this going through some other > tree? I was _assuming_ that I'd get it through the normal printk pull request, it doesn't seem to be that timing-critical. But if there is nothing else pending,

Re: [PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console"

2021-01-07 Thread Greg Kroah-Hartman
On Thu, Jan 07, 2021 at 05:44:00PM +0100, Petr Mladek wrote: > This reverts commit 757055ae8dedf5333af17b3b5b4b70ba9bc9da4e. > > The commit caused that ttynull was used as the default console > on many systems. It happened when there was no console configured > on the command line and

Re: [PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console"

2021-01-07 Thread Linus Torvalds
On Thu, Jan 7, 2021 at 9:45 AM Andy Shevchenko wrote: >> > Shouldn't it have Fixes tag along with Reported-by ones and explanation what > was the actual problem reported? No need for a "Fixes" tag for a revert - the commit it reverts _is_ the thing it fixes, so that's implicitly there. But yes,

Re: [PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console"

2021-01-07 Thread Andy Shevchenko
On Thu, Jan 07, 2021 at 05:44:00PM +0100, Petr Mladek wrote: > This reverts commit 757055ae8dedf5333af17b3b5b4b70ba9bc9da4e. > > The commit caused that ttynull was used as the default console > on many systems. It happened when there was no console configured > on the command line and

[PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console"

2021-01-07 Thread Petr Mladek
This reverts commit 757055ae8dedf5333af17b3b5b4b70ba9bc9da4e. The commit caused that ttynull was used as the default console on many systems. It happened when there was no console configured on the command line and ttynull_init() was the first initcall calling register_console(). The commit