Re: [PATCH 1/1] regulators: bd718x7: Add enable times

2020-12-17 Thread Vaittinen, Matti
On Wed, 2020-12-16 at 13:41 +0100, Guido Günther wrote: > Hi Matti, > On Wed, Dec 16, 2020 at 12:29:20PM +, Vaittinen, Matti wrote: > > Hello Guido, > > > > Thanks for looking at this! > > > > On Wed, 2020-12-16 at 12:05 +0100, Guido Günther wrote: > > > Use the typical startup times from

Re: [PATCH 1/1] regulators: bd718x7: Add enable times

2020-12-16 Thread Vaittinen, Matti
On Wed, 2020-12-16 at 12:48 +, Mark Brown wrote: > On Wed, Dec 16, 2020 at 01:41:33PM +0100, Guido Günther wrote: > > On Wed, Dec 16, 2020 at 12:29:20PM +, Vaittinen, Matti wrote: > > > > + .enable_time = 144, > > > Where are these values obtained from? I have a

Re: [PATCH 1/1] regulators: bd718x7: Add enable times

2020-12-16 Thread Mark Brown
On Wed, Dec 16, 2020 at 01:41:33PM +0100, Guido Günther wrote: > On Wed, Dec 16, 2020 at 12:29:20PM +, Vaittinen, Matti wrote: > > > + .enable_time = 144, > > Where are these values obtained from? I have a feeling they might be > > board / load specific. If this is the case -

Re: [PATCH 1/1] regulators: bd718x7: Add enable times

2020-12-16 Thread Guido Günther
Hi Matti, On Wed, Dec 16, 2020 at 12:29:20PM +, Vaittinen, Matti wrote: > Hello Guido, > > Thanks for looking at this! > > On Wed, 2020-12-16 at 12:05 +0100, Guido Günther wrote: > > Use the typical startup times from the data sheet so boards get a > > reasonable default. Not setting any

Re: [PATCH 1/1] regulators: bd718x7: Add enable times

2020-12-16 Thread Vaittinen, Matti
Hello Guido, Thanks for looking at this! On Wed, 2020-12-16 at 12:05 +0100, Guido Günther wrote: > Use the typical startup times from the data sheet so boards get a > reasonable default. Not setting any enable time can lead to board > hangs > when e.g. clocks are enabled too soon afterwards. >

[PATCH 1/1] regulators: bd718x7: Add enable times

2020-12-16 Thread Guido Günther
Use the typical startup times from the data sheet so boards get a reasonable default. Not setting any enable time can lead to board hangs when e.g. clocks are enabled too soon afterwards. This fixes gpu power domain resume on the Librem 5. Signed-off-by: Guido Günther ---