RE: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-10-16 Thread Keller, Jacob E
et...@vger.kernel.org; tshimizu...@gmail.com; linux- > ker...@vger.kernel.org; haicheng@gmail.com > Subject: Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module > dependency. > > From: Ben Hutchings > Date: Tue, 16 Oct 2012 21:09:27 +0100 > > > I think the vari

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-10-16 Thread David Miller
From: Ben Hutchings Date: Tue, 16 Oct 2012 21:09:27 +0100 > I think the various kconfig options should be changed as follows: > > 1. Only PTP_1588_CLOCK selects PPS. > 2. Nothing depends on EXPERIMENTAL. (This stuff has been in for 18 >months and it's even being backported to RHEL 6 now.)

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-10-16 Thread Ben Hutchings
On Wed, 2012-10-03 at 20:43 -0400, David Miller wrote: > From: Ben Hutchings > Date: Wed, 3 Oct 2012 22:45:10 +0100 > > > I thought of it as being a peripheral feature (which most Solarflare > > hardware doesn't implement) so it made sense for SFC_PTP to be optional > > like SFC_MTD and so on.

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-10-16 Thread Ben Hutchings
On Wed, 2012-10-03 at 20:43 -0400, David Miller wrote: From: Ben Hutchings bhutchi...@solarflare.com Date: Wed, 3 Oct 2012 22:45:10 +0100 I thought of it as being a peripheral feature (which most Solarflare hardware doesn't implement) so it made sense for SFC_PTP to be optional like

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-10-16 Thread David Miller
From: Ben Hutchings bhutchi...@solarflare.com Date: Tue, 16 Oct 2012 21:09:27 +0100 I think the various kconfig options should be changed as follows: 1. Only PTP_1588_CLOCK selects PPS. 2. Nothing depends on EXPERIMENTAL. (This stuff has been in for 18 months and it's even being

RE: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-10-16 Thread Keller, Jacob E
...@gmail.com; linux- ker...@vger.kernel.org; haicheng@gmail.com Subject: Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency. From: Ben Hutchings bhutchi...@solarflare.com Date: Tue, 16 Oct 2012 21:09:27 +0100 I think the various kconfig options should be changed

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-10-03 Thread David Miller
From: Ben Hutchings Date: Wed, 3 Oct 2012 22:45:10 +0100 > I thought of it as being a peripheral feature (which most Solarflare > hardware doesn't implement) so it made sense for SFC_PTP to be optional > like SFC_MTD and so on. But I'm quite happy to use a select instead, if > you want that to

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-10-03 Thread Ben Hutchings
On Tue, 2012-10-02 at 22:22 -0400, David Miller wrote: > From: Haicheng Li > Date: Fri, 28 Sep 2012 14:57:38 +0800 > > > On 09/28/2012 02:46 PM, David Miller wrote: > >> From: Haicheng Li > >> Date: Fri, 28 Sep 2012 14:41:43 +0800 > >> > >>> On 09/28/2012 06:09 AM, David Miller wrote: >

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-10-03 Thread Ben Hutchings
On Tue, 2012-10-02 at 22:22 -0400, David Miller wrote: From: Haicheng Li haicheng...@linux.intel.com Date: Fri, 28 Sep 2012 14:57:38 +0800 On 09/28/2012 02:46 PM, David Miller wrote: From: Haicheng Lihaicheng...@linux.intel.com Date: Fri, 28 Sep 2012 14:41:43 +0800 On 09/28/2012

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-10-03 Thread David Miller
From: Ben Hutchings bhutchi...@solarflare.com Date: Wed, 3 Oct 2012 22:45:10 +0100 I thought of it as being a peripheral feature (which most Solarflare hardware doesn't implement) so it made sense for SFC_PTP to be optional like SFC_MTD and so on. But I'm quite happy to use a select instead,

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-10-02 Thread David Miller
From: Haicheng Li Date: Fri, 28 Sep 2012 14:57:38 +0800 > On 09/28/2012 02:46 PM, David Miller wrote: >> From: Haicheng Li >> Date: Fri, 28 Sep 2012 14:41:43 +0800 >> >>> On 09/28/2012 06:09 AM, David Miller wrote: Look at how other people submit patches, do any other patch submissions

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-10-02 Thread David Miller
From: Haicheng Li haicheng...@linux.intel.com Date: Fri, 28 Sep 2012 14:57:38 +0800 On 09/28/2012 02:46 PM, David Miller wrote: From: Haicheng Lihaicheng...@linux.intel.com Date: Fri, 28 Sep 2012 14:41:43 +0800 On 09/28/2012 06:09 AM, David Miller wrote: Look at how other people submit

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-28 Thread Haicheng Li
On 09/28/2012 02:46 PM, David Miller wrote: From: Haicheng Li Date: Fri, 28 Sep 2012 14:41:43 +0800 On 09/28/2012 06:09 AM, David Miller wrote: Look at how other people submit patches, do any other patch submissions look like your's having all of this metadata in the message body: I'm sorry

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-28 Thread David Miller
From: Haicheng Li Date: Fri, 28 Sep 2012 14:41:43 +0800 > On 09/28/2012 06:09 AM, David Miller wrote: >> Look at how other people submit patches, do any other patch >> submissions >> look like your's having all of this metadata in the message body: > I'm sorry for it. > >> As for this specific

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-28 Thread Haicheng Li
On 09/28/2012 06:09 AM, David Miller wrote: Look at how other people submit patches, do any other patch submissions look like your's having all of this metadata in the message body: I'm sorry for it. As for this specific patch: - depends on PTP_1588_CLOCK_PCH + depends on

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-28 Thread Haicheng Li
On 09/28/2012 06:09 AM, David Miller wrote: Look at how other people submit patches, do any other patch submissions look like your's having all of this metadata in the message body: I'm sorry for it. As for this specific patch: - depends on PTP_1588_CLOCK_PCH + depends on

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-28 Thread David Miller
From: Haicheng Li haicheng...@linux.intel.com Date: Fri, 28 Sep 2012 14:41:43 +0800 On 09/28/2012 06:09 AM, David Miller wrote: Look at how other people submit patches, do any other patch submissions look like your's having all of this metadata in the message body: I'm sorry for it. As

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-28 Thread Haicheng Li
On 09/28/2012 02:46 PM, David Miller wrote: From: Haicheng Lihaicheng...@linux.intel.com Date: Fri, 28 Sep 2012 14:41:43 +0800 On 09/28/2012 06:09 AM, David Miller wrote: Look at how other people submit patches, do any other patch submissions look like your's having all of this metadata in

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-27 Thread David Miller
From: Haicheng Li Date: Tue, 25 Sep 2012 08:23:27 +0800 > From 898e3214b3406c620571cedf704719784b0df049 Mon Sep 17 00:00:00 2001 > From: Haicheng Li > Date: Mon, 24 Sep 2012 15:52:30 +0800 > Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module > dependency. &

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-27 Thread David Miller
: From 898e3214b3406c620571cedf704719784b0df049 Mon Sep 17 00:00:00 2001 From: Haicheng Li haicheng...@linux.intel.com Date: Mon, 24 Sep 2012 15:52:30 +0800 Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency. No, nobody else does this. As for this specific patch

[PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-24 Thread Haicheng Li
From 898e3214b3406c620571cedf704719784b0df049 Mon Sep 17 00:00:00 2001 From: Haicheng Li Date: Mon, 24 Sep 2012 15:52:30 +0800 Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency. The .config is: CONFIG_PCH_GBE=y CONFIG_PCH_PTP=y

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-24 Thread David Miller
Please post all networking patches to net...@vger.kernel.org Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

[Updated PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-24 Thread Haicheng Li
this version would be more clean: From 898e3214b3406c620571cedf704719784b0df049 Mon Sep 17 00:00:00 2001 From: Haicheng Li Date: Mon, 24 Sep 2012 15:52:30 +0800 Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency. The .config is: CONFIG_PCH_GBE=y

[PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-24 Thread Haicheng Li
From 1b4ae11bacfd2eedda1fd0e1ce1d37b678e2f009 Mon Sep 17 00:00:00 2001 From: Haicheng Li Date: Mon, 24 Sep 2012 15:01:33 +0800 Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency. The .config is: CONFIG_PCH_GBE=y CONFIG_PCH_PTP=y

[PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-24 Thread Haicheng Li
From 1b4ae11bacfd2eedda1fd0e1ce1d37b678e2f009 Mon Sep 17 00:00:00 2001 From: Haicheng Li haicheng...@linux.intel.com Date: Mon, 24 Sep 2012 15:01:33 +0800 Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency. The .config is: CONFIG_PCH_GBE=y

[Updated PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-24 Thread Haicheng Li
this version would be more clean: From 898e3214b3406c620571cedf704719784b0df049 Mon Sep 17 00:00:00 2001 From: Haicheng Li haicheng...@linux.intel.com Date: Mon, 24 Sep 2012 15:52:30 +0800 Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency. The .config

Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-24 Thread David Miller
Please post all networking patches to net...@vger.kernel.org Thank you. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

[PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

2012-09-24 Thread Haicheng Li
From 898e3214b3406c620571cedf704719784b0df049 Mon Sep 17 00:00:00 2001 From: Haicheng Li haicheng...@linux.intel.com Date: Mon, 24 Sep 2012 15:52:30 +0800 Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency. The .config is: CONFIG_PCH_GBE=y