Re: [PATCH 1/2] usb: dwc3: gadget: Allow runtime suspend if UDC unbinded

2020-11-03 Thread Wesley Cheng
On 11/3/2020 12:07 PM, Alan Stern wrote: > On Tue, Nov 03, 2020 at 11:02:25AM -0800, Wesley Cheng wrote: >> >> >> On 10/28/2020 6:07 PM, Alan Stern wrote: --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1995,6 +1995,11 @@ static int dwc3_gadget_pullup(struct

Re: [PATCH 1/2] usb: dwc3: gadget: Allow runtime suspend if UDC unbinded

2020-11-03 Thread Alan Stern
On Tue, Nov 03, 2020 at 11:02:25AM -0800, Wesley Cheng wrote: > > > On 10/28/2020 6:07 PM, Alan Stern wrote: > >> --- a/drivers/usb/dwc3/gadget.c > >> +++ b/drivers/usb/dwc3/gadget.c > >> @@ -1995,6 +1995,11 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, > >> int is_on) > >>unsigned

Re: [PATCH 1/2] usb: dwc3: gadget: Allow runtime suspend if UDC unbinded

2020-11-03 Thread Wesley Cheng
On 10/28/2020 6:07 PM, Alan Stern wrote: > On Wed, Oct 28, 2020 at 04:43:10PM -0700, Wesley Cheng wrote: >> The DWC3 runtime suspend routine checks for the USB connected parameter to >> determine if the controller can enter into a low power state. The >> connected state is only set to false

Re: [PATCH 1/2] usb: dwc3: gadget: Allow runtime suspend if UDC unbinded

2020-10-28 Thread Alan Stern
On Wed, Oct 28, 2020 at 04:43:10PM -0700, Wesley Cheng wrote: > The DWC3 runtime suspend routine checks for the USB connected parameter to > determine if the controller can enter into a low power state. The > connected state is only set to false after receiving a disconnect event. > However, in

[PATCH 1/2] usb: dwc3: gadget: Allow runtime suspend if UDC unbinded

2020-10-28 Thread Wesley Cheng
The DWC3 runtime suspend routine checks for the USB connected parameter to determine if the controller can enter into a low power state. The connected state is only set to false after receiving a disconnect event. However, in the case of a device initiated disconnect (i.e. UDC unbind), the