Re: [PATCH 1/20] x86_64: Assembly safe page.h and pgtable.h

2007-03-07 Thread Eric W. Biederman
Vivek Goyal <[EMAIL PROTECTED]> writes: > Hi Sam, > > Thanks for the review. This makes sense to me. Move const.h into > asm-generic and let everybody use it. > > This is more of a small cleanup issue and involves changing few header files > in asm-sparc64 and make sure nothing is broken on

Re: [PATCH 1/20] x86_64: Assembly safe page.h and pgtable.h

2007-03-07 Thread Vivek Goyal
On Wed, Mar 07, 2007 at 08:24:04PM +0100, Sam Ravnborg wrote: > On Wed, Mar 07, 2007 at 12:29:20PM +0530, Vivek Goyal wrote: > > > > > > This patch makes pgtable.h and page.h safe to include > > in assembly files like head.S. Allowing us to use > > symbolic constants instead of hard coded

Re: [PATCH 1/20] x86_64: Assembly safe page.h and pgtable.h

2007-03-07 Thread Sam Ravnborg
On Wed, Mar 07, 2007 at 12:29:20PM +0530, Vivek Goyal wrote: > > > This patch makes pgtable.h and page.h safe to include > in assembly files like head.S. Allowing us to use > symbolic constants instead of hard coded numbers when > refering to the page tables. > > This patch copies

Re: [PATCH 1/20] x86_64: Assembly safe page.h and pgtable.h

2007-03-07 Thread Sam Ravnborg
On Wed, Mar 07, 2007 at 12:29:20PM +0530, Vivek Goyal wrote: This patch makes pgtable.h and page.h safe to include in assembly files like head.S. Allowing us to use symbolic constants instead of hard coded numbers when refering to the page tables. This patch copies asm-sparc64/const.h

Re: [PATCH 1/20] x86_64: Assembly safe page.h and pgtable.h

2007-03-07 Thread Vivek Goyal
On Wed, Mar 07, 2007 at 08:24:04PM +0100, Sam Ravnborg wrote: On Wed, Mar 07, 2007 at 12:29:20PM +0530, Vivek Goyal wrote: This patch makes pgtable.h and page.h safe to include in assembly files like head.S. Allowing us to use symbolic constants instead of hard coded numbers when

Re: [PATCH 1/20] x86_64: Assembly safe page.h and pgtable.h

2007-03-07 Thread Eric W. Biederman
Vivek Goyal [EMAIL PROTECTED] writes: Hi Sam, Thanks for the review. This makes sense to me. Move const.h into asm-generic and let everybody use it. This is more of a small cleanup issue and involves changing few header files in asm-sparc64 and make sure nothing is broken on sparc64. This

[PATCH 1/20] x86_64: Assembly safe page.h and pgtable.h

2007-03-06 Thread Vivek Goyal
This patch makes pgtable.h and page.h safe to include in assembly files like head.S. Allowing us to use symbolic constants instead of hard coded numbers when refering to the page tables. This patch copies asm-sparc64/const.h to asm-x86_64 to get a definition of _AC() a very convinient macro

[PATCH 1/20] x86_64: Assembly safe page.h and pgtable.h

2007-03-06 Thread Vivek Goyal
This patch makes pgtable.h and page.h safe to include in assembly files like head.S. Allowing us to use symbolic constants instead of hard coded numbers when refering to the page tables. This patch copies asm-sparc64/const.h to asm-x86_64 to get a definition of _AC() a very convinient macro