Re: [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-08 Thread Chris Ruehl
On Monday, December 09, 2013 12:07 PM, Felipe Balbi wrote: Hi, On Mon, Dec 09, 2013 at 09:45:30AM +0800, Chris Ruehl wrote: On Saturday, December 07, 2013 04:24 AM, Felipe Balbi wrote: Hi, On Mon, Dec 02, 2013 at 03:05:17PM +0800, Chris Ruehl wrote: @@ -231,27 +249,40 @@ static int

Re: [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-08 Thread Felipe Balbi
Hi, On Mon, Dec 09, 2013 at 09:45:30AM +0800, Chris Ruehl wrote: > On Saturday, December 07, 2013 04:24 AM, Felipe Balbi wrote: > >Hi, > > > >On Mon, Dec 02, 2013 at 03:05:17PM +0800, Chris Ruehl wrote: > >>@@ -231,27 +249,40 @@ static int usb_phy_gen_xceiv_probe(struct > >>platform_device

Re: [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-08 Thread Chris Ruehl
On Saturday, December 07, 2013 04:24 AM, Felipe Balbi wrote: Hi, On Mon, Dec 02, 2013 at 03:05:17PM +0800, Chris Ruehl wrote: @@ -231,27 +249,40 @@ static int usb_phy_gen_xceiv_probe(struct platform_device *pdev) return -ENOMEM; nop->reset_active_low = true;/*

Re: [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-08 Thread Chris Ruehl
On Saturday, December 07, 2013 04:24 AM, Felipe Balbi wrote: Hi, On Mon, Dec 02, 2013 at 03:05:17PM +0800, Chris Ruehl wrote: @@ -231,27 +249,40 @@ static int usb_phy_gen_xceiv_probe(struct platform_device *pdev) return -ENOMEM; nop-reset_active_low = true;/*

Re: [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-08 Thread Felipe Balbi
Hi, On Mon, Dec 09, 2013 at 09:45:30AM +0800, Chris Ruehl wrote: On Saturday, December 07, 2013 04:24 AM, Felipe Balbi wrote: Hi, On Mon, Dec 02, 2013 at 03:05:17PM +0800, Chris Ruehl wrote: @@ -231,27 +249,40 @@ static int usb_phy_gen_xceiv_probe(struct platform_device *pdev)

Re: [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-08 Thread Chris Ruehl
On Monday, December 09, 2013 12:07 PM, Felipe Balbi wrote: Hi, On Mon, Dec 09, 2013 at 09:45:30AM +0800, Chris Ruehl wrote: On Saturday, December 07, 2013 04:24 AM, Felipe Balbi wrote: Hi, On Mon, Dec 02, 2013 at 03:05:17PM +0800, Chris Ruehl wrote: @@ -231,27 +249,40 @@ static int

Re: [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-06 Thread Felipe Balbi
Hi, On Mon, Dec 02, 2013 at 03:05:17PM +0800, Chris Ruehl wrote: > @@ -231,27 +249,40 @@ static int usb_phy_gen_xceiv_probe(struct > platform_device *pdev) > return -ENOMEM; > > nop->reset_active_low = true; /* default behaviour */ > + nop->cs_active_low = true; > >

Re: [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-06 Thread Felipe Balbi
Hi, On Mon, Dec 02, 2013 at 03:05:17PM +0800, Chris Ruehl wrote: @@ -231,27 +249,40 @@ static int usb_phy_gen_xceiv_probe(struct platform_device *pdev) return -ENOMEM; nop-reset_active_low = true; /* default behaviour */ + nop-cs_active_low = true; if

[PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-01 Thread Chris Ruehl
usb: phy-generic: Add GPIO based ChipSelect The ULPI ISP1504 uses the CHIP_SELECT_N (low active) pin to active the chip. This patch add support for GPIO based ChipSelect almost the same way implemented for the Reset feature. Sample DT configuration: pinctrl_usbphy2: usbphy-2 { fsl,pins = <

[PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-01 Thread Chris Ruehl
usb: phy-generic: Add GPIO based ChipSelect The ULPI ISP1504 uses the CHIP_SELECT_N (low active) pin to active the chip. This patch add support for GPIO based ChipSelect almost the same way implemented for the Reset feature. Sample DT configuration: pinctrl_usbphy2: usbphy-2 { fsl,pins =