Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-02 Thread Jonas Bonn
Hi Joe, On 12/02/2013 06:48 AM, Joe Perches wrote: (Adding Jonas Bonn to list as he added the macro in the first place...) Thanks... ;) Actually, I think I submitted an even uglier macro called DECLARE_PCI_DEVICE_TABLE... might have been the first kernel patch I ever sent? In any case, it

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-02 Thread Jonas Bonn
Hi Joe, On 12/02/2013 06:48 AM, Joe Perches wrote: (Adding Jonas Bonn to list as he added the macro in the first place...) Thanks... ;) Actually, I think I submitted an even uglier macro called DECLARE_PCI_DEVICE_TABLE... might have been the first kernel patch I ever sent? In any case, it

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-01 Thread Joe Perches
(Adding Jonas Bonn to list as he added the macro in the first place...) On Mon, 2013-12-02 at 13:03 +0900, Jingoo Han wrote: > On Monday, December 02, 2013 12:56 PM, Guenter Roeck wrote: > > On 12/01/2013 07:50 PM, Jingoo Han wrote: > > > On Monday, December 02, 2013 12:46 PM, Guenter Roeck

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-01 Thread Jingoo Han
On Monday, December 02, 2013 12:56 PM, Guenter Roeck wrote: > On 12/01/2013 07:50 PM, Jingoo Han wrote: > > On Monday, December 02, 2013 12:46 PM, Guenter Roeck wrote: > >> On 12/01/2013 04:07 PM, Jingoo Han wrote: > >>> On Friday, November 29, 2013 10:34 AM, Jingoo Han wrote: > On Thursday,

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-01 Thread Guenter Roeck
On 12/01/2013 07:50 PM, Jingoo Han wrote: On Monday, December 02, 2013 12:46 PM, Guenter Roeck wrote: On 12/01/2013 04:07 PM, Jingoo Han wrote: On Friday, November 29, 2013 10:34 AM, Jingoo Han wrote: On Thursday, November 28, 2013 3:24 PM, Joe Perches wrote: On Wed, 2013-11-27 at 21:53

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-01 Thread Jingoo Han
On Monday, December 02, 2013 12:46 PM, Guenter Roeck wrote: > On 12/01/2013 04:07 PM, Jingoo Han wrote: > > On Friday, November 29, 2013 10:34 AM, Jingoo Han wrote: > >> On Thursday, November 28, 2013 3:24 PM, Joe Perches wrote: > >>> On Wed, 2013-11-27 at 21:53 -0800, 'Greg Kroah-Hartman' wrote:

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-01 Thread Guenter Roeck
On 12/01/2013 04:07 PM, Jingoo Han wrote: On Friday, November 29, 2013 10:34 AM, Jingoo Han wrote: On Thursday, November 28, 2013 3:24 PM, Joe Perches wrote: On Wed, 2013-11-27 at 21:53 -0800, 'Greg Kroah-Hartman' wrote: On Wed, Nov 27, 2013 at 09:40:13PM -0800, Joe Perches wrote: On Thu,

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-01 Thread Jingoo Han
On Friday, November 29, 2013 10:34 AM, Jingoo Han wrote: > On Thursday, November 28, 2013 3:24 PM, Joe Perches wrote: > >On Wed, 2013-11-27 at 21:53 -0800, 'Greg Kroah-Hartman' wrote: > >>On Wed, Nov 27, 2013 at 09:40:13PM -0800, Joe Perches wrote: > >>>On Thu, 2013-11-28 at 14:29 +0900, Jingoo

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-01 Thread Jingoo Han
On Friday, November 29, 2013 10:34 AM, Jingoo Han wrote: On Thursday, November 28, 2013 3:24 PM, Joe Perches wrote: On Wed, 2013-11-27 at 21:53 -0800, 'Greg Kroah-Hartman' wrote: On Wed, Nov 27, 2013 at 09:40:13PM -0800, Joe Perches wrote: On Thu, 2013-11-28 at 14:29 +0900, Jingoo Han wrote:

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-01 Thread Guenter Roeck
On 12/01/2013 04:07 PM, Jingoo Han wrote: On Friday, November 29, 2013 10:34 AM, Jingoo Han wrote: On Thursday, November 28, 2013 3:24 PM, Joe Perches wrote: On Wed, 2013-11-27 at 21:53 -0800, 'Greg Kroah-Hartman' wrote: On Wed, Nov 27, 2013 at 09:40:13PM -0800, Joe Perches wrote: On Thu,

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-01 Thread Jingoo Han
On Monday, December 02, 2013 12:46 PM, Guenter Roeck wrote: On 12/01/2013 04:07 PM, Jingoo Han wrote: On Friday, November 29, 2013 10:34 AM, Jingoo Han wrote: On Thursday, November 28, 2013 3:24 PM, Joe Perches wrote: On Wed, 2013-11-27 at 21:53 -0800, 'Greg Kroah-Hartman' wrote: On Wed,

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-01 Thread Guenter Roeck
On 12/01/2013 07:50 PM, Jingoo Han wrote: On Monday, December 02, 2013 12:46 PM, Guenter Roeck wrote: On 12/01/2013 04:07 PM, Jingoo Han wrote: On Friday, November 29, 2013 10:34 AM, Jingoo Han wrote: On Thursday, November 28, 2013 3:24 PM, Joe Perches wrote: On Wed, 2013-11-27 at 21:53

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-01 Thread Jingoo Han
On Monday, December 02, 2013 12:56 PM, Guenter Roeck wrote: On 12/01/2013 07:50 PM, Jingoo Han wrote: On Monday, December 02, 2013 12:46 PM, Guenter Roeck wrote: On 12/01/2013 04:07 PM, Jingoo Han wrote: On Friday, November 29, 2013 10:34 AM, Jingoo Han wrote: On Thursday, November 28,

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-01 Thread Joe Perches
(Adding Jonas Bonn to list as he added the macro in the first place...) On Mon, 2013-12-02 at 13:03 +0900, Jingoo Han wrote: On Monday, December 02, 2013 12:56 PM, Guenter Roeck wrote: On 12/01/2013 07:50 PM, Jingoo Han wrote: On Monday, December 02, 2013 12:46 PM, Guenter Roeck wrote:

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-28 Thread Jingoo Han
On Thursday, November 28, 2013 3:24 PM, Joe Perches wrote: >On Wed, 2013-11-27 at 21:53 -0800, 'Greg Kroah-Hartman' wrote: >>On Wed, Nov 27, 2013 at 09:40:13PM -0800, Joe Perches wrote: >>>On Thu, 2013-11-28 at 14:29 +0900, Jingoo Han wrote: On Thursday, November 28, 2013 1:08 PM, Greg

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-28 Thread Jingoo Han
On Thursday, November 28, 2013 3:24 PM, Joe Perches wrote: On Wed, 2013-11-27 at 21:53 -0800, 'Greg Kroah-Hartman' wrote: On Wed, Nov 27, 2013 at 09:40:13PM -0800, Joe Perches wrote: On Thu, 2013-11-28 at 14:29 +0900, Jingoo Han wrote: On Thursday, November 28, 2013 1:08 PM, Greg Kroah-Hartman

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Joe Perches
On Wed, 2013-11-27 at 21:53 -0800, 'Greg Kroah-Hartman' wrote: > On Wed, Nov 27, 2013 at 09:40:13PM -0800, Joe Perches wrote: > > On Thu, 2013-11-28 at 14:29 +0900, Jingoo Han wrote: > > > On Thursday, November 28, 2013 1:08 PM, Greg Kroah-Hartman wrote: > > > > On Thu, Nov 28, 2013 at 10:55:35AM

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread 'Greg Kroah-Hartman'
On Wed, Nov 27, 2013 at 09:40:13PM -0800, Joe Perches wrote: > On Thu, 2013-11-28 at 14:29 +0900, Jingoo Han wrote: > > On Thursday, November 28, 2013 1:08 PM, Greg Kroah-Hartman wrote: > > > On Thu, Nov 28, 2013 at 10:55:35AM +0900, Jingoo Han wrote: > > > > This macro is used to create a struct

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Joe Perches
On Thu, 2013-11-28 at 14:29 +0900, Jingoo Han wrote: > On Thursday, November 28, 2013 1:08 PM, Greg Kroah-Hartman wrote: > > On Thu, Nov 28, 2013 at 10:55:35AM +0900, Jingoo Han wrote: > > > This macro is used to create a struct pci_device_id array. > > > > Yeah, and it's a horrid macro that

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
On Thursday, November 28, 2013 1:08 PM, Greg Kroah-Hartman wrote: > On Thu, Nov 28, 2013 at 10:55:35AM +0900, Jingoo Han wrote: > > This macro is used to create a struct pci_device_id array. > > Yeah, and it's a horrid macro that deserves to be removed, please don't > use it in more places. > >

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
On Thursday, November 28, 2013 1:08 PM, Greg Kroah-Hartman wrote: On Thu, Nov 28, 2013 at 10:55:35AM +0900, Jingoo Han wrote: This macro is used to create a struct pci_device_id array. Yeah, and it's a horrid macro that deserves to be removed, please don't use it in more places.

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Joe Perches
On Thu, 2013-11-28 at 14:29 +0900, Jingoo Han wrote: On Thursday, November 28, 2013 1:08 PM, Greg Kroah-Hartman wrote: On Thu, Nov 28, 2013 at 10:55:35AM +0900, Jingoo Han wrote: This macro is used to create a struct pci_device_id array. Yeah, and it's a horrid macro that deserves to be

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread 'Greg Kroah-Hartman'
On Wed, Nov 27, 2013 at 09:40:13PM -0800, Joe Perches wrote: On Thu, 2013-11-28 at 14:29 +0900, Jingoo Han wrote: On Thursday, November 28, 2013 1:08 PM, Greg Kroah-Hartman wrote: On Thu, Nov 28, 2013 at 10:55:35AM +0900, Jingoo Han wrote: This macro is used to create a struct

Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Joe Perches
On Wed, 2013-11-27 at 21:53 -0800, 'Greg Kroah-Hartman' wrote: On Wed, Nov 27, 2013 at 09:40:13PM -0800, Joe Perches wrote: On Thu, 2013-11-28 at 14:29 +0900, Jingoo Han wrote: On Thursday, November 28, 2013 1:08 PM, Greg Kroah-Hartman wrote: On Thu, Nov 28, 2013 at 10:55:35AM +0900,