Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

Hi! > > > Signed-off-by: Vivek Goyal <[EMAIL PROTECTED]> > > > > > +static int swsusp_header_init(void) > > > +{ > > > + swsusp_header = (struct swsusp_header*) __get_free_page(GFP_KERNEL); > > > + if (!swsusp_header) > > > + panic("Could not allocate memory for swsusp_header\n"); > > >

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

Hi! > > > o virt_to_page() call should be used on kernel linear addresses and not > > > on kernel text and data addresses. Swsusp code uses it on kernel data > > > (statically allocated swsusp_header). > > > > > > o Allocate swsusp_header dynamically so that virt_to_page() can be used > > >

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

Hi! o virt_to_page() call should be used on kernel linear addresses and not on kernel text and data addresses. Swsusp code uses it on kernel data (statically allocated swsusp_header). o Allocate swsusp_header dynamically so that virt_to_page() can be used safely. o

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

Hi! Signed-off-by: Vivek Goyal [EMAIL PROTECTED] +static int swsusp_header_init(void) +{ + swsusp_header = (struct swsusp_header*) __get_free_page(GFP_KERNEL); + if (!swsusp_header) + panic(Could not allocate memory for swsusp_header\n); + return 0; +} +

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

On Wed, Mar 07, 2007 at 11:49:15PM +0100, Pavel Machek wrote: > Hi! > > > o virt_to_page() call should be used on kernel linear addresses and not > > on kernel text and data addresses. Swsusp code uses it on kernel data > > (statically allocated swsusp_header). > > > > o Allocate

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

On Wed, Mar 07, 2007 at 11:50:06PM +0100, Pavel Machek wrote: > Hi! > > > o virt_to_page() call should be used on kernel linear addresses and not > > on kernel text and data addresses. Swsusp code uses it on kernel data > > (statically allocated swsusp_header). > > > > o Allocate

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

Hi. On Wed, 2007-03-07 at 23:50 +0100, Pavel Machek wrote: > Hi! > > > o virt_to_page() call should be used on kernel linear addresses and not > > on kernel text and data addresses. Swsusp code uses it on kernel data > > (statically allocated swsusp_header). > > > > o Allocate swsusp_header

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

Hi! > o virt_to_page() call should be used on kernel linear addresses and not > on kernel text and data addresses. Swsusp code uses it on kernel data > (statically allocated swsusp_header). > > o Allocate swsusp_header dynamically so that virt_to_page() can be used > safely. > > o I am

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

Hi! > o virt_to_page() call should be used on kernel linear addresses and not > on kernel text and data addresses. Swsusp code uses it on kernel data > (statically allocated swsusp_header). > > o Allocate swsusp_header dynamically so that virt_to_page() can be used > safely. > > o I am

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

Hi! o virt_to_page() call should be used on kernel linear addresses and not on kernel text and data addresses. Swsusp code uses it on kernel data (statically allocated swsusp_header). o Allocate swsusp_header dynamically so that virt_to_page() can be used safely. o I am changing

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

Hi! o virt_to_page() call should be used on kernel linear addresses and not on kernel text and data addresses. Swsusp code uses it on kernel data (statically allocated swsusp_header). o Allocate swsusp_header dynamically so that virt_to_page() can be used safely. o I am changing

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

Hi. On Wed, 2007-03-07 at 23:50 +0100, Pavel Machek wrote: Hi! o virt_to_page() call should be used on kernel linear addresses and not on kernel text and data addresses. Swsusp code uses it on kernel data (statically allocated swsusp_header). o Allocate swsusp_header dynamically

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

On Wed, Mar 07, 2007 at 11:50:06PM +0100, Pavel Machek wrote: Hi! o virt_to_page() call should be used on kernel linear addresses and not on kernel text and data addresses. Swsusp code uses it on kernel data (statically allocated swsusp_header). o Allocate swsusp_header

Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

On Wed, Mar 07, 2007 at 11:49:15PM +0100, Pavel Machek wrote: Hi! o virt_to_page() call should be used on kernel linear addresses and not on kernel text and data addresses. Swsusp code uses it on kernel data (statically allocated swsusp_header). o Allocate swsusp_header

[PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

o virt_to_page() call should be used on kernel linear addresses and not on kernel text and data addresses. Swsusp code uses it on kernel data (statically allocated swsusp_header). o Allocate swsusp_header dynamically so that virt_to_page() can be used safely. o I am changing this because

[PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

o virt_to_page() call should be used on kernel linear addresses and not on kernel text and data addresses. Swsusp code uses it on kernel data (statically allocated swsusp_header). o Allocate swsusp_header dynamically so that virt_to_page() can be used safely. o I am changing this because