Re: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip

2019-03-29 Thread Paul Walmsley
On Wed, 20 Mar 2019, Yash Shah wrote: > This EDAC driver supports: > - Initial configuration reporting on bootup via debug logs > - ECC event monitoring and reporting through the EDAC framework > - ECC event injection > > This driver is partially based on pnd2_edac.c and altera_edac.c > >

Re: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip

2019-03-25 Thread Borislav Petkov
On Mon, Mar 25, 2019 at 02:26:52PM -0700, Paul Walmsley wrote: > We'll definitely take the RAM savings that a few #ifdefs will deliver to > us. They add up. We're selling chips for embedded use cases, not just > big-iron x86 systems. Fair enough. Btw, while we're at it, this driver would

Re: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip

2019-03-25 Thread Paul Walmsley
On Mon, 25 Mar 2019, Borislav Petkov wrote: > On Sun, Mar 24, 2019 at 05:23:27PM -0700, Paul Walmsley wrote: > > > + if (!IS_ENABLED(CONFIG_EDAC_DEBUG)) > > > + return; > > > > Can all of these debugfs functions be wrapped with an #if ... #endif such > > that, if CONFIG_EDAC_DEBUG is

Re: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip

2019-03-25 Thread Borislav Petkov
On Sun, Mar 24, 2019 at 05:23:27PM -0700, Paul Walmsley wrote: > > + if (!IS_ENABLED(CONFIG_EDAC_DEBUG)) > > + return; > > Can all of these debugfs functions be wrapped with an #if ... #endif such > that, if CONFIG_EDAC_DEBUG is not set, they will all be stripped out by > the

Re: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip

2019-03-24 Thread Paul Walmsley
Hi Yash, Just a few brief comments here: On Wed, 20 Mar 2019, Yash Shah wrote: > This EDAC driver supports: > - Initial configuration reporting on bootup via debug logs > - ECC event monitoring and reporting through the EDAC framework > - ECC event injection > It's probably worth mentioning

Re: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip

2019-03-22 Thread Yash Shah
On Thu, Mar 21, 2019 at 7:03 PM Borislav Petkov wrote: > > On Wed, Mar 20, 2019 at 05:22:08PM +0530, Yash Shah wrote: > > This EDAC driver supports: > > - Initial configuration reporting on bootup via debug logs > > - ECC event monitoring and reporting through the EDAC framework > > - ECC event

Re: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip

2019-03-21 Thread Borislav Petkov
On Wed, Mar 20, 2019 at 05:22:08PM +0530, Yash Shah wrote: > This EDAC driver supports: > - Initial configuration reporting on bootup via debug logs > - ECC event monitoring and reporting through the EDAC framework > - ECC event injection > > This driver is partially based on pnd2_edac.c and

[PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip

2019-03-20 Thread Yash Shah
This EDAC driver supports: - Initial configuration reporting on bootup via debug logs - ECC event monitoring and reporting through the EDAC framework - ECC event injection This driver is partially based on pnd2_edac.c and altera_edac.c Initially L2 Cache controller is added as a subcomponent to