Re: [PATCH 2/2] sifive: edac: Add EDAC driver for Sifive l2 Cache Controller

2019-03-25 Thread Borislav Petkov
On Mon, Mar 25, 2019 at 02:18:39PM -0700, Paul Walmsley wrote: > All of these drivers are for single IP blocks. Mostly DRAM controllers. > There's no "platform EDAC manager" IP block in these cases. Maybe because they have RAS functionality in one single IP block. Others like altera_edac, for

Re: [PATCH 2/2] sifive: edac: Add EDAC driver for Sifive l2 Cache Controller

2019-03-25 Thread Paul Walmsley
On Mon, 25 Mar 2019, Borislav Petkov wrote: > On Sun, Mar 24, 2019 at 05:16:17PM -0700, Paul Walmsley wrote: > > Looking at the Synopsys, > > Look again at synopsys_edac. > > > Highbank, > > Yes, that one and octeon. > > > PowerPC 4xx, and > > also a single ppc4xx_edac driver. > > > TI EDAC

Re: [PATCH 2/2] sifive: edac: Add EDAC driver for Sifive l2 Cache Controller

2019-03-25 Thread Borislav Petkov
On Sun, Mar 24, 2019 at 05:16:17PM -0700, Paul Walmsley wrote: > Looking at the Synopsys, Look again at synopsys_edac. > Highbank, Yes, that one and octeon. > PowerPC 4xx, and also a single ppc4xx_edac driver. > TI EDAC drivers, There's TI drivers, plural? I see only ti_edac.c. Also,

Re: [PATCH 2/2] sifive: edac: Add EDAC driver for Sifive l2 Cache Controller

2019-03-24 Thread Paul Walmsley
On Tue, 12 Mar 2019, Borislav Petkov wrote: > Please no EDAC drivers for a single functional unit with RAS > capabilities. Rather, a sifive_edac or riscv_edac driver which covers > the whole platform or even architecture and contains support for all the > RAS functionality there. See altera_edac,

Re: [PATCH 2/2] sifive: edac: Add EDAC driver for Sifive l2 Cache Controller

2019-03-12 Thread Paul Walmsley
Hello Yash, On Tue, 12 Mar 2019, Yash Shah wrote: > Add driver for the SiFive L2 cache controller > on the HiFive Unleashed board This should read "for the SiFive FU540-C000 chip" or something similar. The L2 cache controller is not specific to the HiFive Unleashed board. Could you also

Re: [PATCH 2/2] sifive: edac: Add EDAC driver for Sifive l2 Cache Controller

2019-03-12 Thread Borislav Petkov
On Tue, Mar 12, 2019 at 02:51:01PM +0530, Yash Shah wrote: > Add driver for the SiFive L2 cache controller > on the HiFive Unleashed board > > Signed-off-by: Yash Shah > --- > arch/riscv/Kconfig| 1 + > drivers/edac/Kconfig | 7 + > drivers/edac/Makefile | 1 +

[PATCH 2/2] sifive: edac: Add EDAC driver for Sifive l2 Cache Controller

2019-03-12 Thread Yash Shah
Add driver for the SiFive L2 cache controller on the HiFive Unleashed board Signed-off-by: Yash Shah --- arch/riscv/Kconfig| 1 + drivers/edac/Kconfig | 7 + drivers/edac/Makefile | 1 + drivers/edac/sifive_edac-l2.c | 292