Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-19 Thread Yang Shi
On 1/18/18 1:02 AM, Thomas Gleixner wrote: On Thu, 18 Jan 2018, Yang Shi wrote: On 1/17/18 4:21 AM, Thomas Gleixner wrote: There are two things which can be done here: 1) The collected objects can be put on a global free list and work scheduled to free them piecewise. I don't get

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-19 Thread Yang Shi
On 1/18/18 1:02 AM, Thomas Gleixner wrote: On Thu, 18 Jan 2018, Yang Shi wrote: On 1/17/18 4:21 AM, Thomas Gleixner wrote: There are two things which can be done here: 1) The collected objects can be put on a global free list and work scheduled to free them piecewise. I don't get

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-18 Thread Thomas Gleixner
On Thu, 18 Jan 2018, Peter Zijlstra wrote: > On Thu, Jan 18, 2018 at 10:02:25AM +0100, Thomas Gleixner wrote: > > > > 2) We can do a cond_resched() if not in atomic context and interrupts > > > > are > > > > enabled. > > > > > > I did try this before I went with touching softlockup

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-18 Thread Thomas Gleixner
On Thu, 18 Jan 2018, Peter Zijlstra wrote: > On Thu, Jan 18, 2018 at 10:02:25AM +0100, Thomas Gleixner wrote: > > > > 2) We can do a cond_resched() if not in atomic context and interrupts > > > > are > > > > enabled. > > > > > > I did try this before I went with touching softlockup

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-18 Thread Peter Zijlstra
On Thu, Jan 18, 2018 at 10:02:25AM +0100, Thomas Gleixner wrote: > > > 2) We can do a cond_resched() if not in atomic context and interrupts > > > are > > > enabled. > > > > I did try this before I went with touching softlockup watchdog approach. The > > problem is in_atomic() can't tell

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-18 Thread Peter Zijlstra
On Thu, Jan 18, 2018 at 10:02:25AM +0100, Thomas Gleixner wrote: > > > 2) We can do a cond_resched() if not in atomic context and interrupts > > > are > > > enabled. > > > > I did try this before I went with touching softlockup watchdog approach. The > > problem is in_atomic() can't tell

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-18 Thread Thomas Gleixner
On Thu, 18 Jan 2018, Yang Shi wrote: > On 1/17/18 4:21 AM, Thomas Gleixner wrote: > > There are two things which can be done here: > > > > 1) The collected objects can be put on a global free list and work > > scheduled to free them piecewise. > > I don't get your point here. objects free

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-18 Thread Thomas Gleixner
On Thu, 18 Jan 2018, Yang Shi wrote: > On 1/17/18 4:21 AM, Thomas Gleixner wrote: > > There are two things which can be done here: > > > > 1) The collected objects can be put on a global free list and work > > scheduled to free them piecewise. > > I don't get your point here. objects free

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-17 Thread Yang Shi
On 1/17/18 4:21 AM, Thomas Gleixner wrote: On Thu, 4 Jan 2018, Yang Shi wrote: There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT occasionally, like below: Please trim back traces. The whole

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-17 Thread Yang Shi
On 1/17/18 4:21 AM, Thomas Gleixner wrote: On Thu, 4 Jan 2018, Yang Shi wrote: There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT occasionally, like below: Please trim back traces. The whole

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-17 Thread Thomas Gleixner
On Thu, 4 Jan 2018, Yang Shi wrote: > There are nested loops on debug objects free path, sometimes it may take > over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT > occasionally, like below: Please trim back traces. The whole module info and whatever is completely

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-17 Thread Thomas Gleixner
On Thu, 4 Jan 2018, Yang Shi wrote: > There are nested loops on debug objects free path, sometimes it may take > over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT > occasionally, like below: Please trim back traces. The whole module info and whatever is completely

[PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-03 Thread Yang Shi
There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT occasionally, like below: NMI watchdog: BUG: soft lockup - CPU#15 stuck for 22s! [stress-ng-getde:110342] Modules linked in: binfmt_misc(E)

[PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-03 Thread Yang Shi
There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT occasionally, like below: NMI watchdog: BUG: soft lockup - CPU#15 stuck for 22s! [stress-ng-getde:110342] Modules linked in: binfmt_misc(E)

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-03 Thread Yang Shi
On 12/28/17 7:36 AM, Thomas Gleixner wrote: On Fri, 8 Dec 2017, Yang Shi wrote: Hi Thomas, Waiman has reviewed the patches, any comment from you is appreciated. I'm confused there is a V3 and a V8 of the 2/2 patch in my inbox. Can you please resend both patches in their final version?

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2018-01-03 Thread Yang Shi
On 12/28/17 7:36 AM, Thomas Gleixner wrote: On Fri, 8 Dec 2017, Yang Shi wrote: Hi Thomas, Waiman has reviewed the patches, any comment from you is appreciated. I'm confused there is a V3 and a V8 of the 2/2 patch in my inbox. Can you please resend both patches in their final version?

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2017-12-28 Thread Thomas Gleixner
On Fri, 8 Dec 2017, Yang Shi wrote: > Hi Thomas, > > Waiman has reviewed the patches, any comment from you is appreciated. I'm confused there is a V3 and a V8 of the 2/2 patch in my inbox. Can you please resend both patches in their final version? Thanks, tglx

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2017-12-28 Thread Thomas Gleixner
On Fri, 8 Dec 2017, Yang Shi wrote: > Hi Thomas, > > Waiman has reviewed the patches, any comment from you is appreciated. I'm confused there is a V3 and a V8 of the 2/2 patch in my inbox. Can you please resend both patches in their final version? Thanks, tglx

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2017-12-07 Thread Yang Shi
Hi Thomas, Waiman has reviewed the patches, any comment from you is appreciated. Thanks, Yang On 11/28/17 12:24 PM, Waiman Long wrote: On 11/28/2017 02:45 PM, Yang Shi wrote: There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cause

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2017-12-07 Thread Yang Shi
Hi Thomas, Waiman has reviewed the patches, any comment from you is appreciated. Thanks, Yang On 11/28/17 12:24 PM, Waiman Long wrote: On 11/28/2017 02:45 PM, Yang Shi wrote: There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cause

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2017-11-28 Thread Waiman Long
On 11/28/2017 02:45 PM, Yang Shi wrote: > There are nested loops on debug objects free path, sometimes it may take > over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT > occasionally, like below: > > NMI watchdog: BUG: soft lockup - CPU#15 stuck for 22s! >

Re: [PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2017-11-28 Thread Waiman Long
On 11/28/2017 02:45 PM, Yang Shi wrote: > There are nested loops on debug objects free path, sometimes it may take > over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT > occasionally, like below: > > NMI watchdog: BUG: soft lockup - CPU#15 stuck for 22s! >

[PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2017-11-28 Thread Yang Shi
There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT occasionally, like below: NMI watchdog: BUG: soft lockup - CPU#15 stuck for 22s! [stress-ng-getde:110342] Modules linked in: binfmt_misc(E)

[PATCH 2/2 v3] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2017-11-28 Thread Yang Shi
There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT occasionally, like below: NMI watchdog: BUG: soft lockup - CPU#15 stuck for 22s! [stress-ng-getde:110342] Modules linked in: binfmt_misc(E)