Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2021-02-12 Thread Johannes Berg
On Fri, 2021-02-12 at 09:42 +0100, Johannes Berg wrote: > On Tue, 2020-12-15 at 22:53 +0530, Youghandhar Chintala wrote: > > The right fix would be to pull the entire data path into the host > > +++ b/net/mac80211/ieee80211_i.h > > @@ -748,6 +748,8 @@ struct ieee80211_if_mesh { > > * back to

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2021-02-12 Thread Johannes Berg
On Tue, 2020-12-15 at 22:53 +0530, Youghandhar Chintala wrote: > The right fix would be to pull the entire data path into the host > +++ b/net/mac80211/ieee80211_i.h > @@ -748,6 +748,8 @@ struct ieee80211_if_mesh { > * back to wireless media and to the local net stack. > *

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2021-02-12 Thread Johannes Berg
On Fri, 2021-02-05 at 13:51 -0800, Abhishek Kumar wrote: > Since using DELBA frame to APs to re-establish BA session has a > dependency on APs and also some APs may not honour the DELBA frame. That's completely out of spec ... Can you say which AP this was? You could also try sending a BAR that

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2021-02-08 Thread Guenter Roeck
On Tue, Dec 15, 2020 at 10:53:52PM +0530, Youghandhar Chintala wrote: > Currently in case of target hardware restart, we just reconfig and > re-enable the security keys and enable the network queues to start > data traffic back from where it was interrupted. > > Many ath10k wifi chipsets have

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2021-02-05 Thread Abhishek Kumar
Since using DELBA frame to APs to re-establish BA session has a dependency on APs and also some APs may not honour the DELBA frame. I am fine with having the disconnect/reconnect solution. The change looks good to me. Reviewed-by: Abhishek Kumar Thanks Abhishek On Thu, Jan 28, 2021 at 12:08 AM

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2021-01-28 Thread youghand
On 2020-12-15 23:10, Felix Fietkau wrote: On 2020-12-15 18:23, Youghandhar Chintala wrote: Currently in case of target hardware restart, we just reconfig and re-enable the security keys and enable the network queues to start data traffic back from where it was interrupted. Many ath10k wifi

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2020-12-15 Thread Felix Fietkau
On 2020-12-15 18:23, Youghandhar Chintala wrote: > Currently in case of target hardware restart, we just reconfig and > re-enable the security keys and enable the network queues to start > data traffic back from where it was interrupted. > > Many ath10k wifi chipsets have sequence numbers for

[PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2020-12-15 Thread Youghandhar Chintala
Currently in case of target hardware restart, we just reconfig and re-enable the security keys and enable the network queues to start data traffic back from where it was interrupted. Many ath10k wifi chipsets have sequence numbers for the data packets assigned by firmware and the mac sequence