Re: [PATCH 2/5] drm/sun4i: tcon: set sync polarity for tcon1 channel

2021-02-09 Thread Maxime Ripard
On Fri, Feb 05, 2021 at 07:47:17PM +0100, Jernej Škrabec wrote: > Dne petek, 05. februar 2021 ob 17:28:23 CET je Chen-Yu Tsai napisal(a): > > On Sat, Feb 6, 2021 at 12:21 AM Jernej Škrabec > wrote: > > > > > > Dne petek, 05. februar 2021 ob 17:01:30 CET je Maxime Ripard napisal(a): > > > > On

Re: [PATCH 2/5] drm/sun4i: tcon: set sync polarity for tcon1 channel

2021-02-05 Thread Maxime Ripard
On Fri, Feb 05, 2021 at 11:21:22AM +0800, Chen-Yu Tsai wrote: > On Fri, Feb 5, 2021 at 2:48 AM Jernej Skrabec wrote: > > > > Channel 1 has polarity bits for vsync and hsync signals but driver never > > sets them. It turns out that with pre-HDMI2 controllers seemingly there > > is no issue if

Re: Re: [PATCH 2/5] drm/sun4i: tcon: set sync polarity for tcon1 channel

2021-02-05 Thread Jernej Škrabec
Dne petek, 05. februar 2021 ob 17:01:30 CET je Maxime Ripard napisal(a): > On Fri, Feb 05, 2021 at 11:21:22AM +0800, Chen-Yu Tsai wrote: > > On Fri, Feb 5, 2021 at 2:48 AM Jernej Skrabec wrote: > > > > > > Channel 1 has polarity bits for vsync and hsync signals but driver never > > > sets them.

Re: Re: [PATCH 2/5] drm/sun4i: tcon: set sync polarity for tcon1 channel

2021-02-05 Thread Chen-Yu Tsai
On Sat, Feb 6, 2021 at 12:21 AM Jernej Škrabec wrote: > > Dne petek, 05. februar 2021 ob 17:01:30 CET je Maxime Ripard napisal(a): > > On Fri, Feb 05, 2021 at 11:21:22AM +0800, Chen-Yu Tsai wrote: > > > On Fri, Feb 5, 2021 at 2:48 AM Jernej Skrabec > wrote: > > > > > > > > Channel 1 has polarity

Re: Re: Re: [PATCH 2/5] drm/sun4i: tcon: set sync polarity for tcon1 channel

2021-02-05 Thread Jernej Škrabec
Dne petek, 05. februar 2021 ob 17:28:23 CET je Chen-Yu Tsai napisal(a): > On Sat, Feb 6, 2021 at 12:21 AM Jernej Škrabec wrote: > > > > Dne petek, 05. februar 2021 ob 17:01:30 CET je Maxime Ripard napisal(a): > > > On Fri, Feb 05, 2021 at 11:21:22AM +0800, Chen-Yu Tsai wrote: > > > > On Fri, Feb

Re: [PATCH 2/5] drm/sun4i: tcon: set sync polarity for tcon1 channel

2021-02-04 Thread Chen-Yu Tsai
On Fri, Feb 5, 2021 at 2:48 AM Jernej Skrabec wrote: > > Channel 1 has polarity bits for vsync and hsync signals but driver never > sets them. It turns out that with pre-HDMI2 controllers seemingly there > is no issue if polarity is not set. However, with HDMI2 controllers > (H6) there often

[PATCH 2/5] drm/sun4i: tcon: set sync polarity for tcon1 channel

2021-02-04 Thread Jernej Skrabec
Channel 1 has polarity bits for vsync and hsync signals but driver never sets them. It turns out that with pre-HDMI2 controllers seemingly there is no issue if polarity is not set. However, with HDMI2 controllers (H6) there often comes to de-synchronization due to phase shift. This causes