RE: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-11 Thread Yoshihiro Shimoda
Hi again, > From: Yoshihiro Shimoda, Sent: Friday, December 11, 2020 9:49 AM > > > but as I said - these are only 'nit' comments and I am not insisting on > > changing these. Especially since some of the comments are more related > > to changing the original bd9571mwv than adding support for

RE: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-10 Thread Yoshihiro Shimoda
Hi Matti-san, > From: Vaittinen, Matti, Sent: Thursday, December 10, 2020 8:56 PM > > Hi Yoshihiro san, > > On Thu, 2020-12-10 at 10:58 +, Yoshihiro Shimoda wrote: > > Hi Matti, > > > > > From: Vaittinen, Matti, Sent: Thursday, December 10, 2020 5:28 PM > > > > > > On Tue, 2020-12-08 at

Re: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-10 Thread Vaittinen, Matti
Hi Yoshihiro san, On Thu, 2020-12-10 at 10:58 +, Yoshihiro Shimoda wrote: > Hi Matti, > > > From: Vaittinen, Matti, Sent: Thursday, December 10, 2020 5:28 PM > > > > On Tue, 2020-12-08 at 17:04 +0900, Yoshihiro Shimoda wrote: > > > From: Khiem Nguyen > > > > > > The new PMIC BD9574MWF

RE: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-10 Thread Yoshihiro Shimoda
Hi Matti, > From: Vaittinen, Matti, Sent: Thursday, December 10, 2020 5:28 PM > > On Tue, 2020-12-08 at 17:04 +0900, Yoshihiro Shimoda wrote: > > From: Khiem Nguyen > > > > The new PMIC BD9574MWF inherits features from BD9571MWV. > > Add the support of new PMIC to existing bd9571mwv driver. > >

Re: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-10 Thread Vaittinen, Matti
On Thu, 2020-12-10 at 09:19 +0100, Geert Uytterhoeven wrote: > Hi Matti, Shimoda-san, > > On Thu, Dec 10, 2020 at 8:33 AM Vaittinen, Matti > wrote: > > On Thu, 2020-12-10 at 04:44 +, Yoshihiro Shimoda wrote: > > > > From: Geert Uytterhoeven, Sent: Wednesday, December 9, 2020 > > > > 10:30 >

RE: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-10 Thread Yoshihiro Shimoda
Hi Geert-san, Matti, Thank you for your comments! > From: Geert Uytterhoeven, Sent: Thursday, December 10, 2020 5:20 PM > > Hi Matti, Shimoda-san, > > On Thu, Dec 10, 2020 at 8:33 AM Vaittinen, Matti > wrote: > > On Thu, 2020-12-10 at 04:44 +, Yoshihiro Shimoda wrote: > > > > From: Geert

Re: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-10 Thread Vaittinen, Matti
On Tue, 2020-12-08 at 17:04 +0900, Yoshihiro Shimoda wrote: > From: Khiem Nguyen > > The new PMIC BD9574MWF inherits features from BD9571MWV. > Add the support of new PMIC to existing bd9571mwv driver. > > Signed-off-by: Khiem Nguyen > [shimoda: rebase and refactor] > Signed-off-by: Yoshihiro

Re: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-10 Thread Geert Uytterhoeven
Hi Matti, Shimoda-san, On Thu, Dec 10, 2020 at 8:33 AM Vaittinen, Matti wrote: > On Thu, 2020-12-10 at 04:44 +, Yoshihiro Shimoda wrote: > > > From: Geert Uytterhoeven, Sent: Wednesday, December 9, 2020 10:30 > > > PM > > > > > > --- a/drivers/mfd/bd9571mwv.c > > > > +++

Re: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-09 Thread Vaittinen, Matti
On Thu, 2020-12-10 at 04:44 +, Yoshihiro Shimoda wrote: > Hi Geert-san, > > Thank you for your review! > > > From: Geert Uytterhoeven, Sent: Wednesday, December 9, 2020 10:30 > > PM > > > > --- a/drivers/mfd/bd9571mwv.c > > > +++ b/drivers/mfd/bd9571mwv.c > > > > > > @@ -182,6 +272,8 @@

Re: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-09 Thread Vaittinen, Matti
Hi deee Ho Yoshihiro-san, Geert, All, On Wed, 2020-12-09 at 14:30 +0100, Geert Uytterhoeven wrote: > Hi Shimoda-san, > > CC Matti (BD9573/6 driver for R-Car platforms) Thank Geert! I wouldn't have noticed this :) > > (I don't have the BD9574 datasheet, so I have to base my review on >

RE: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-09 Thread Yoshihiro Shimoda
Hi Geert-san, Thank you for your review! > From: Geert Uytterhoeven, Sent: Wednesday, December 9, 2020 10:30 PM > > --- a/drivers/mfd/bd9571mwv.c > > +++ b/drivers/mfd/bd9571mwv.c > > @@ -20,6 +20,7 @@ static const struct mfd_cell bd9571mwv_cells[] = { > > { .name = "bd9571mwv-gpio",

Re: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-09 Thread Geert Uytterhoeven
Hi Shimoda-san, CC Matti (BD9573/6 driver for R-Car platforms) (I don't have the BD9574 datasheet, so I have to base my review on https://www.rohm.com/r-car-pmic) On Tue, Dec 8, 2020 at 9:06 AM Yoshihiro Shimoda wrote: > From: Khiem Nguyen > > The new PMIC BD9574MWF inherits features from

[PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-08 Thread Yoshihiro Shimoda
From: Khiem Nguyen The new PMIC BD9574MWF inherits features from BD9571MWV. Add the support of new PMIC to existing bd9571mwv driver. Signed-off-by: Khiem Nguyen [shimoda: rebase and refactor] Signed-off-by: Yoshihiro Shimoda --- drivers/mfd/bd9571mwv.c | 92