Re: [PATCH 3/4] KVM: selftests: Introduce VM_MODE_PXXV48_4K

2019-08-28 Thread Peter Xu
On Wed, Aug 28, 2019 at 01:41:04PM +0200, Andrew Jones wrote: [...] > > +#define DEBUG printf > > If this is going to be some general thing, then maybe we should do it > like this > > #ifndef NDEBUG > #define dprintf printf > #endif Ok. > > > > + > > /* Minimum allocated guest virtual and

Re: [PATCH 3/4] KVM: selftests: Introduce VM_MODE_PXXV48_4K

2019-08-28 Thread Andrew Jones
On Tue, Aug 27, 2019 at 09:10:14PM +0800, Peter Xu wrote: > The naming VM_MODE_P52V48_4K is explicit but unclear when used on > x86_64 machines, because x86_64 machines are having various physical > address width rather than some static values. Here's some examples: > > - Intel Xeon E3-1220:

[PATCH 3/4] KVM: selftests: Introduce VM_MODE_PXXV48_4K

2019-08-27 Thread Peter Xu
The naming VM_MODE_P52V48_4K is explicit but unclear when used on x86_64 machines, because x86_64 machines are having various physical address width rather than some static values. Here's some examples: - Intel Xeon E3-1220: 36 bits - Intel Core i7-8650: 39 bits - AMD EPYC 7251: 48