Re: [PATCH 5.9 RT] net: openvswitch: Fix using smp_processor_id() in preemptible code

2020-10-12 Thread Eelco Chaudron
On 12 Oct 2020, at 10:21, Sebastian Andrzej Siewior wrote: On 2020-10-12 10:14:42 [+0200], Eelco Chaudron wrote: On 9 Oct 2020, at 17:41, Sebastian Andrzej Siewior wrote: On 2020-10-09 14:47:59 [+0200], Juri Lelli wrote: This happens because openvswitch/flow_table::flow_lookup()

Re: [PATCH 5.9 RT] net: openvswitch: Fix using smp_processor_id() in preemptible code

2020-10-12 Thread Sebastian Andrzej Siewior
On 2020-10-12 10:14:42 [+0200], Eelco Chaudron wrote: > > > On 9 Oct 2020, at 17:41, Sebastian Andrzej Siewior wrote: > > > On 2020-10-09 14:47:59 [+0200], Juri Lelli wrote: > > > This happens because openvswitch/flow_table::flow_lookup() accesses > > > per-cpu data while being preemptible (and

Re: [PATCH 5.9 RT] net: openvswitch: Fix using smp_processor_id() in preemptible code

2020-10-12 Thread Eelco Chaudron
On 9 Oct 2020, at 17:41, Sebastian Andrzej Siewior wrote: On 2020-10-09 14:47:59 [+0200], Juri Lelli wrote: This happens because openvswitch/flow_table::flow_lookup() accesses per-cpu data while being preemptible (and migratable). Fix it by adding get/put_cpu_light(), so that, even if

Re: [PATCH 5.9 RT] net: openvswitch: Fix using smp_processor_id() in preemptible code

2020-10-09 Thread Sebastian Andrzej Siewior
On 2020-10-09 14:47:59 [+0200], Juri Lelli wrote: > This happens because openvswitch/flow_table::flow_lookup() accesses > per-cpu data while being preemptible (and migratable). > > Fix it by adding get/put_cpu_light(), so that, even if preempted, the > task executing this code is not migrated

Re: [PATCH 5.9 RT] net: openvswitch: Fix using smp_processor_id() in preemptible code

2020-10-09 Thread Juri Lelli
On 09/10/20 14:47, Juri Lelli wrote: > The following BUG has been reported (slightly edited): > > BUG: using smp_processor_id() in preemptible [] code: handler106/3082 > caller is flow_lookup.isra.15+0x2c/0xf0 [openvswitch] > CPU: 46 PID: 3082 Comm: handler106 Not tainted ... #1 >

[PATCH 5.9 RT] net: openvswitch: Fix using smp_processor_id() in preemptible code

2020-10-09 Thread Juri Lelli
The following BUG has been reported (slightly edited): BUG: using smp_processor_id() in preemptible [] code: handler106/3082 caller is flow_lookup.isra.15+0x2c/0xf0 [openvswitch] CPU: 46 PID: 3082 Comm: handler106 Not tainted ... #1 Hardware name: Dell Inc. PowerEdge R640/06DKY5, BIOS