Re: [PATCH 6/7 v3] sched/fair: trigger the update of blocked load on newly idle cpu

2021-02-17 Thread Vincent Guittot
On Wed, 17 Feb 2021 at 12:51, Valentin Schneider wrote: > > On 15/02/21 16:02, Vincent Guittot wrote: > > On Fri, 12 Feb 2021 at 20:19, Valentin Schneider > > wrote: > >> I don't think there is anything inherently wrong with it - the > >> nohz_idle_balance() call resulting from the kick_ilb()

Re: [PATCH 6/7 v3] sched/fair: trigger the update of blocked load on newly idle cpu

2021-02-17 Thread Valentin Schneider
On 15/02/21 16:02, Vincent Guittot wrote: > On Fri, 12 Feb 2021 at 20:19, Valentin Schneider > wrote: >> I don't think there is anything inherently wrong with it - the >> nohz_idle_balance() call resulting from the kick_ilb() IPI will just bail >> out due to the flags being cleared here. This

Re: [PATCH 6/7 v3] sched/fair: trigger the update of blocked load on newly idle cpu

2021-02-15 Thread Vincent Guittot
On Fri, 12 Feb 2021 at 20:19, Valentin Schneider wrote: > > On 12/02/21 15:17, Vincent Guittot wrote: > > Instead of waking up a random and already idle CPU, we can take advantage > > of this_cpu being about to enter idle to run the ILB and update the > > blocked load. > > > > Signed-off-by:

Re: [PATCH 6/7 v3] sched/fair: trigger the update of blocked load on newly idle cpu

2021-02-12 Thread Valentin Schneider
On 12/02/21 15:17, Vincent Guittot wrote: > Instead of waking up a random and already idle CPU, we can take advantage > of this_cpu being about to enter idle to run the ILB and update the > blocked load. > > Signed-off-by: Vincent Guittot > --- > kernel/sched/fair.c | 24

[PATCH 6/7 v3] sched/fair: trigger the update of blocked load on newly idle cpu

2021-02-12 Thread Vincent Guittot
Instead of waking up a random and already idle CPU, we can take advantage of this_cpu being about to enter idle to run the ILB and update the blocked load. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 24 +--- kernel/sched/idle.c | 6 ++