Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Tue, May 15, 2018 at 09:58:03PM -0700, Andy Lutomirski wrote: > > > > On May 15, 2018, at 8:11 PM, Frederic Weisbecker > > wrote: > > > >> On Wed, May 09, 2018 at 11:17:03AM +0200, Peter Zijlstra wrote: > >>> On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Tue, May 15, 2018 at 09:58:03PM -0700, Andy Lutomirski wrote: > > > > On May 15, 2018, at 8:11 PM, Frederic Weisbecker > > wrote: > > > >> On Wed, May 09, 2018 at 11:17:03AM +0200, Peter Zijlstra wrote: > >>> On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic Weisbecker wrote: > >>>

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

> On May 15, 2018, at 8:11 PM, Frederic Weisbecker wrote: > >> On Wed, May 09, 2018 at 11:17:03AM +0200, Peter Zijlstra wrote: >>> On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic Weisbecker wrote: >>> arch/arm/include/asm/hw_breakpoint.h | 5 - >>>

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

> On May 15, 2018, at 8:11 PM, Frederic Weisbecker wrote: > >> On Wed, May 09, 2018 at 11:17:03AM +0200, Peter Zijlstra wrote: >>> On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic Weisbecker wrote: >>> arch/arm/include/asm/hw_breakpoint.h | 5 - >>> arch/arm/kernel/hw_breakpoint.c

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Wed, May 09, 2018 at 11:17:03AM +0200, Peter Zijlstra wrote: > On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic Weisbecker wrote: > > arch/arm/include/asm/hw_breakpoint.h | 5 - > > arch/arm/kernel/hw_breakpoint.c | 22 +++--- > >

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Wed, May 09, 2018 at 11:17:03AM +0200, Peter Zijlstra wrote: > On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic Weisbecker wrote: > > arch/arm/include/asm/hw_breakpoint.h | 5 - > > arch/arm/kernel/hw_breakpoint.c | 22 +++--- > >

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Tue, May 15, 2018 at 03:53:00PM +0200, Frederic Weisbecker wrote: > On Mon, May 07, 2018 at 12:46:06AM +, Joel Fernandes wrote: > > On Sun, May 6, 2018 at 12:22 PM Frederic Weisbecker > > wrote: > > > > > arch_validate_hwbkpt_settings() mixes up attribute check and

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Tue, May 15, 2018 at 03:53:00PM +0200, Frederic Weisbecker wrote: > On Mon, May 07, 2018 at 12:46:06AM +, Joel Fernandes wrote: > > On Sun, May 6, 2018 at 12:22 PM Frederic Weisbecker > > wrote: > > > > > arch_validate_hwbkpt_settings() mixes up attribute check and commit into > > > a

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Tue, May 15, 2018 at 08:57:47AM +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic Weisbecker wrote: > > > arch/arm/include/asm/hw_breakpoint.h | 5 - > > > arch/arm/kernel/hw_breakpoint.c |

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Tue, May 15, 2018 at 08:57:47AM +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic Weisbecker wrote: > > > arch/arm/include/asm/hw_breakpoint.h | 5 - > > > arch/arm/kernel/hw_breakpoint.c | 22

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Mon, May 07, 2018 at 12:46:06AM +, Joel Fernandes wrote: > On Sun, May 6, 2018 at 12:22 PM Frederic Weisbecker > wrote: > > > arch_validate_hwbkpt_settings() mixes up attribute check and commit into > > a single code entity. Therefore the validation may return an

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Mon, May 07, 2018 at 12:46:06AM +, Joel Fernandes wrote: > On Sun, May 6, 2018 at 12:22 PM Frederic Weisbecker > wrote: > > > arch_validate_hwbkpt_settings() mixes up attribute check and commit into > > a single code entity. Therefore the validation may return an error due to > >

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

* Peter Zijlstra wrote: > On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic Weisbecker wrote: > > arch/arm/include/asm/hw_breakpoint.h | 5 - > > arch/arm/kernel/hw_breakpoint.c | 22 +++--- > > arch/arm64/include/asm/hw_breakpoint.h |

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

* Peter Zijlstra wrote: > On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic Weisbecker wrote: > > arch/arm/include/asm/hw_breakpoint.h | 5 - > > arch/arm/kernel/hw_breakpoint.c | 22 +++--- > > arch/arm64/include/asm/hw_breakpoint.h | 5 - > >

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic Weisbecker wrote: > arch/arm/include/asm/hw_breakpoint.h | 5 - > arch/arm/kernel/hw_breakpoint.c | 22 +++--- > arch/arm64/include/asm/hw_breakpoint.h | 5 - > arch/arm64/kernel/hw_breakpoint.c|

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Sun, May 06, 2018 at 09:19:54PM +0200, Frederic Weisbecker wrote: > arch/arm/include/asm/hw_breakpoint.h | 5 - > arch/arm/kernel/hw_breakpoint.c | 22 +++--- > arch/arm64/include/asm/hw_breakpoint.h | 5 - > arch/arm64/kernel/hw_breakpoint.c|

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Sun, May 6, 2018 at 12:22 PM Frederic Weisbecker wrote: > arch_validate_hwbkpt_settings() mixes up attribute check and commit into > a single code entity. Therefore the validation may return an error due to > incorrect atributes while still leaving halfway modified

Re: [PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

On Sun, May 6, 2018 at 12:22 PM Frederic Weisbecker wrote: > arch_validate_hwbkpt_settings() mixes up attribute check and commit into > a single code entity. Therefore the validation may return an error due to > incorrect atributes while still leaving halfway modified architecture > breakpoint

[PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

arch_validate_hwbkpt_settings() mixes up attribute check and commit into a single code entity. Therefore the validation may return an error due to incorrect atributes while still leaving halfway modified architecture breakpoint struct. Now that we have split its logic on all archs, we can remove

[PATCH 8/9] perf/breakpoint: Split breakpoint "check" and "commit"

arch_validate_hwbkpt_settings() mixes up attribute check and commit into a single code entity. Therefore the validation may return an error due to incorrect atributes while still leaving halfway modified architecture breakpoint struct. Now that we have split its logic on all archs, we can remove