Re: [PATCH V2] nvme-rdma: fix double free in nvme_rdma_free_queue

2018-05-17 Thread jianchao.wang
Hi Max Thanks for kindly review and suggestion for this. On 05/16/2018 08:18 PM, Max Gurtovoy wrote: > I don't know exactly what Christoph meant but IMO the best place to allocate > it is in nvme_rdma_alloc_queue just before calling > > "set_bit(NVME_RDMA_Q_ALLOCATED, >flags);" > > then you

Re: [PATCH V2] nvme-rdma: fix double free in nvme_rdma_free_queue

2018-05-17 Thread jianchao.wang
Hi Max Thanks for kindly review and suggestion for this. On 05/16/2018 08:18 PM, Max Gurtovoy wrote: > I don't know exactly what Christoph meant but IMO the best place to allocate > it is in nvme_rdma_alloc_queue just before calling > > "set_bit(NVME_RDMA_Q_ALLOCATED, >flags);" > > then you

Re: [PATCH V2] nvme-rdma: fix double free in nvme_rdma_free_queue

2018-05-16 Thread Max Gurtovoy
Hi Jianchao, On 5/10/2018 12:42 PM, Jianchao Wang wrote: BUG: KASAN: double-free or invalid-free in nvme_rdma_free_queue+0xf6/0x110 [nvme_rdma] Workqueue: nvme-reset-wq nvme_rdma_reset_ctrl_work [nvme_rdma] Call Trace: dump_stack+0x91/0xeb print_address_description+0x6b/0x290

Re: [PATCH V2] nvme-rdma: fix double free in nvme_rdma_free_queue

2018-05-16 Thread Max Gurtovoy
Hi Jianchao, On 5/10/2018 12:42 PM, Jianchao Wang wrote: BUG: KASAN: double-free or invalid-free in nvme_rdma_free_queue+0xf6/0x110 [nvme_rdma] Workqueue: nvme-reset-wq nvme_rdma_reset_ctrl_work [nvme_rdma] Call Trace: dump_stack+0x91/0xeb print_address_description+0x6b/0x290

[PATCH V2] nvme-rdma: fix double free in nvme_rdma_free_queue

2018-05-10 Thread Jianchao Wang
BUG: KASAN: double-free or invalid-free in nvme_rdma_free_queue+0xf6/0x110 [nvme_rdma] Workqueue: nvme-reset-wq nvme_rdma_reset_ctrl_work [nvme_rdma] Call Trace: dump_stack+0x91/0xeb print_address_description+0x6b/0x290 kasan_report_invalid_free+0x55/0x80 __kasan_slab_free+0x176/0x190

[PATCH V2] nvme-rdma: fix double free in nvme_rdma_free_queue

2018-05-10 Thread Jianchao Wang
BUG: KASAN: double-free or invalid-free in nvme_rdma_free_queue+0xf6/0x110 [nvme_rdma] Workqueue: nvme-reset-wq nvme_rdma_reset_ctrl_work [nvme_rdma] Call Trace: dump_stack+0x91/0xeb print_address_description+0x6b/0x290 kasan_report_invalid_free+0x55/0x80 __kasan_slab_free+0x176/0x190