Re: [PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

On 2018/1/18 22:25, Andrew Lunn wrote: +static int hclge_set_led_status_phy(struct phy_device *phydev, int value) +{ + int ret, cur_page; + + mutex_lock(>lock); + + ret = phy_read(phydev, HCLGE_PHY_PAGE_REG); + if (ret < 0) + goto out; + else +

Re: [PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

On 2018/1/18 22:25, Andrew Lunn wrote: +static int hclge_set_led_status_phy(struct phy_device *phydev, int value) +{ + int ret, cur_page; + + mutex_lock(>lock); + + ret = phy_read(phydev, HCLGE_PHY_PAGE_REG); + if (ret < 0) + goto out; + else +

Re: [PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

> +static int hclge_set_led_status_phy(struct phy_device *phydev, int value) > +{ > + int ret, cur_page; > + > + mutex_lock(>lock); > + > + ret = phy_read(phydev, HCLGE_PHY_PAGE_REG); > + if (ret < 0) > + goto out; > + else > + cur_page = ret; > + > +

Re: [PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

> +static int hclge_set_led_status_phy(struct phy_device *phydev, int value) > +{ > + int ret, cur_page; > + > + mutex_lock(>lock); > + > + ret = phy_read(phydev, HCLGE_PHY_PAGE_REG); > + if (ret < 0) > + goto out; > + else > + cur_page = ret; > + > +

[PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

From: Jian Shen Add led location support for phy device. The led will keep blinking with frequency 2HZ when locating. Signed-off-by: Jian Shen Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hnae3.h|

[PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

From: Jian Shen Add led location support for phy device. The led will keep blinking with frequency 2HZ when locating. Signed-off-by: Jian Shen Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 2 + drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 12 +++