Re: [PATCH next v1 1/3] printk: track/limit recursion

2021-03-24 Thread Petr Mladek
On Tue 2021-03-23 22:32:00, John Ogness wrote: > On 2021-03-22, Petr Mladek wrote: > > On Wed 2021-03-17 00:33:24, John Ogness wrote: > >> Track printk() recursion and limit it to 3 levels per-CPU and per-context. > > > >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > >> index

Re: [PATCH next v1 1/3] printk: track/limit recursion

2021-03-23 Thread John Ogness
On 2021-03-22, Petr Mladek wrote: > On Wed 2021-03-17 00:33:24, John Ogness wrote: >> Track printk() recursion and limit it to 3 levels per-CPU and per-context. > > Please, explain why it is added. I mean that it will > allow remove printk_safe that provides recursion protection at the > moment.

Re: [PATCH next v1 1/3] printk: track/limit recursion

2021-03-22 Thread Petr Mladek
On Mon 2021-03-22 20:13:51, Sergey Senozhatsky wrote: > On (21/03/22 11:53), John Ogness wrote: > > On 2021-03-21, Sergey Senozhatsky wrote: > > >> @@ -2055,6 +2122,9 @@ int vprintk_store(int facility, int level, > > >> */ > > >> ts_nsec = local_clock(); > > >> > > >> +

Re: [PATCH next v1 1/3] printk: track/limit recursion

2021-03-22 Thread Petr Mladek
On Wed 2021-03-17 00:33:24, John Ogness wrote: > Track printk() recursion and limit it to 3 levels per-CPU and per-context. Please, explain why it is added. I mean that it will allow remove printk_safe that provides recursion protection at the moment. > Signed-off-by: John Ogness > --- >

Re: [PATCH next v1 1/3] printk: track/limit recursion

2021-03-22 Thread Sergey Senozhatsky
On (21/03/22 11:53), John Ogness wrote: > On 2021-03-21, Sergey Senozhatsky wrote: > >> @@ -2055,6 +2122,9 @@ int vprintk_store(int facility, int level, > >> */ > >>ts_nsec = local_clock(); > >> > >> + if (!printk_enter_irqsave()) > >> + return 0; > > > > I guess it can be

Re: [PATCH next v1 1/3] printk: track/limit recursion

2021-03-22 Thread John Ogness
On 2021-03-21, Sergey Senozhatsky wrote: >> @@ -2055,6 +2122,9 @@ int vprintk_store(int facility, int level, >> */ >> ts_nsec = local_clock(); >> >> +if (!printk_enter_irqsave()) >> +return 0; > > I guess it can be interesting to somehow signal us that we had >

Re: [PATCH next v1 1/3] printk: track/limit recursion

2021-03-20 Thread Sergey Senozhatsky
On (21/03/17 00:33), John Ogness wrote: [..] > static inline void printk_delay(void) > @@ -2040,11 +2105,13 @@ int vprintk_store(int facility, int level, > struct prb_reserved_entry e; > enum log_flags lflags = 0; > struct printk_record r; > + unsigned long irqflags; >

[PATCH next v1 1/3] printk: track/limit recursion

2021-03-16 Thread John Ogness
Track printk() recursion and limit it to 3 levels per-CPU and per-context. Signed-off-by: John Ogness --- kernel/printk/printk.c | 80 -- 1 file changed, 77 insertions(+), 3 deletions(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index