Re: [PATCH v1] panic: push panic() messages to the console even from the MCE nmi handler

2021-01-11 Thread William Roche
Thank you for your clarification, and let me explain what I was talking about before providing my last code version. kmsg_dump(KMSG_DUMP_PANIC); + panic_flush_to_console(); > > This is wrong. kmsg_dump() flushes the messages into the registered > dumpers, e.g. pstore. It

Re: [PATCH v1] panic: push panic() messages to the console even from the MCE nmi handler

2021-01-08 Thread Petr Mladek
On Fri 2021-01-08 01:26:06, William Roche wrote: > On 06/01/2021 05:35, Sergey Senozhatsky wrote: > > On (21/01/04 16:15), “William Roche wrote: > >> @@ -271,9 +280,8 @@ void panic(const char *fmt, ...) > >> */ > >>atomic_notifier_call_chain(_notifier_list, 0, buf); > >> > >> - /* Call

Re: [PATCH v1] panic: push panic() messages to the console even from the MCE nmi handler

2021-01-08 Thread Petr Mladek
On Mon 2021-01-04 16:15:55, “William Roche wrote: > From: William Roche > > Force push panic messages to the console as panic() can be called from NMI > interrupt handler functions where printed messages can't always reach the > console without an explicit push provided by

Re: [PATCH v1] panic: push panic() messages to the console even from the MCE nmi handler

2021-01-07 Thread William Roche
On 06/01/2021 05:35, Sergey Senozhatsky wrote: > On (21/01/04 16:15), “William Roche wrote: > [..] >> diff --git a/kernel/panic.c b/kernel/panic.c >> index 332736a..eb90cc0 100644 >> --- a/kernel/panic.c >> +++ b/kernel/panic.c >> @@ -166,6 +166,15 @@ static void panic_print_sys_info(void) >>

Re: [PATCH v1] panic: push panic() messages to the console even from the MCE nmi handler

2021-01-05 Thread Sergey Senozhatsky
On (21/01/04 16:15), “William Roche wrote: [..] > diff --git a/kernel/panic.c b/kernel/panic.c > index 332736a..eb90cc0 100644 > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -166,6 +166,15 @@ static void panic_print_sys_info(void) > ftrace_dump(DUMP_ALL); > } > > +/* > + *

[PATCH v1] panic: push panic() messages to the console even from the MCE nmi handler

2021-01-04 Thread “William Roche
From: William Roche Force push panic messages to the console as panic() can be called from NMI interrupt handler functions where printed messages can't always reach the console without an explicit push provided by printk_safe_flush_on_panic() and console_flush_on_panic(). This is the case with