Re: [PATCH v1 06/18] media: hantro: Make sure that ctx->codex_ops is set

2021-02-18 Thread Dan Carpenter
On Wed, Feb 17, 2021 at 09:02:54AM +0100, Benjamin Gaignard wrote: > Do not try to call ctx->codec_ops->done if ctx->codec_ops is not set. > When you're writing a patch like this please say in the commit message if this can happen or not. Option 1: Option 1: sometimes this is NULL in Option

Re: [PATCH v1 06/18] media: hantro: Make sure that ctx->codex_ops is set

2021-02-17 Thread Ezequiel Garcia
On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Do not try to call ctx->codec_ops->done if ctx->codec_ops is not set. > If codec_ops is not set for a codec variant, things will go south really fast. See hantro_start_streaming for instance. I think you can just drop this patch.

[PATCH v1 06/18] media: hantro: Make sure that ctx->codex_ops is set

2021-02-17 Thread Benjamin Gaignard
Do not try to call ctx->codec_ops->done if ctx->codec_ops is not set. Signed-off-by: Benjamin Gaignard Signed-off-by: Ezequiel Garcia Signed-off-by: Adrian Ratiu --- drivers/staging/media/hantro/hantro_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git